-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat #149] 채팅 요청 수락 시 채팅 요청 메시지를 채팅방 메시지에 저장 #150
Conversation
Test Results 28 files 28 suites 13s ⏱️ Results for commit be2e6b0. ♻️ This comment has been updated with latest results. |
Code Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다~!
++
지난 번 chatInquiry과 chatRoom의 정의 설명해주신 답글 확인했습니다!
chatInquiry.message필드가 채팅방 메시지인줄 알았는데, 요청 메시지였군요. 덕분에 전반적인 흐름이 이해가 되었네요!
creditHistoryService.saveCreditHistoryInMemberIds(rejectedInquirerIds, CreditType.CHAT_REFUND, CHAT_REWARD); | ||
creditHistoryService.saveCreditHistoryInMemberIds( | ||
rejectedInquirerIds, CreditType.CHAT_REFUND, CHAT_REWARD | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음..시간이 지나 자동 거절 되었을 때 알람을 안보내도 될까요?
조금 애매하군요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
알림이 있는게 더 자연스러울 것 같아요~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음..넵 한번 추가해보겠습니다!
return chatRoom.getInquirer(); | ||
} else if (member.isEqualMember(chatRoom.getInquirer().getId())) { | ||
} | ||
if (member.equals(chatRoom.getInquirer())) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
반영 감사합니다~!!
관련 이슈
📑 작업 상세 내용
💫 작업 요약
🔍 중점적으로 리뷰 할 부분