Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat #149] 채팅 요청 수락 시 채팅 요청 메시지를 채팅방 메시지에 저장 #150

Merged
merged 10 commits into from
Nov 21, 2024

Conversation

hyun2371
Copy link
Member

관련 이슈

📑 작업 상세 내용

  • 요청 수락 시 요청 메시지 -> 채팅 메시지에 저장
  • 채팅 요청 관련 에러 코드 추가
  • 이전 pr 리뷰 반영

💫 작업 요약

  • 채팅 요청 수락 시 메시지에 채팅 메시지 저장

🔍 중점적으로 리뷰 할 부분

@hyun2371 hyun2371 added the ✨ feat 기능 추가 label Nov 20, 2024
@hyun2371 hyun2371 requested a review from dudxo November 20, 2024 12:53
@hyun2371 hyun2371 self-assigned this Nov 20, 2024
@hyun2371 hyun2371 changed the title [feat #149] 채팅방 요청 수락 -> 채팅 요청 메시지를 채팅방 메시지에 저장 [feat #149] 채팅 요청 수락 시 채팅 요청 메시지를 채팅방 메시지에 저장 Nov 20, 2024
Copy link

github-actions bot commented Nov 20, 2024

Test Results

 28 files   28 suites   13s ⏱️
128 tests 128 ✅ 0 💤 0 ❌
129 runs  129 ✅ 0 💤 0 ❌

Results for commit be2e6b0.

♻️ This comment has been updated with latest results.

Copy link

Code Coverage

Overall Project 85.15% -0.58% 🍏
Files changed 67.42% 🍏

File Coverage
ChatRoomService.java 96.15% 🍏
Member.java 93.53% -1.18% 🍏
ChatInquiryService.java 90.1% -4.95% 🍏
ChatInquiry.java 84.13% -15.87%
InquiryStatus.java 50% -14.58%

Copy link
Collaborator

@dudxo dudxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~!

++
지난 번 chatInquiry과 chatRoom의 정의 설명해주신 답글 확인했습니다!
chatInquiry.message필드가 채팅방 메시지인줄 알았는데, 요청 메시지였군요. 덕분에 전반적인 흐름이 이해가 되었네요!

creditHistoryService.saveCreditHistoryInMemberIds(rejectedInquirerIds, CreditType.CHAT_REFUND, CHAT_REWARD);
creditHistoryService.saveCreditHistoryInMemberIds(
rejectedInquirerIds, CreditType.CHAT_REFUND, CHAT_REWARD
);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

음..시간이 지나 자동 거절 되었을 때 알람을 안보내도 될까요?
조금 애매하군요

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

알림이 있는게 더 자연스러울 것 같아요~

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

음..넵 한번 추가해보겠습니다!

return chatRoom.getInquirer();
} else if (member.isEqualMember(chatRoom.getInquirer().getId())) {
}
if (member.equals(chatRoom.getInquirer())) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영 감사합니다~!!

@hyun2371 hyun2371 merged commit 503175d into dev Nov 21, 2024
3 checks passed
@hyun2371 hyun2371 deleted the feat/#149/save-inquiry-message-to-chat branch November 21, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feat 기능 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ 채팅 요청 수락 시 채팅 요청 메시지를 채팅방 메시지에 저장
2 participants