Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat #92] 채팅방 메시지 조회 API #93

Merged
merged 18 commits into from
Aug 29, 2024
Merged

[feat #92] 채팅방 메시지 조회 API #93

merged 18 commits into from
Aug 29, 2024

Conversation

hyun2371
Copy link
Member

관련 이슈

📑 작업 상세 내용

  • mongoDB 세팅
    • docker-compose.yml 작성
    • test container에 mongo container 추가
  • 채팅 메시지 저장 API
    • DB에 저장되는지 확인차 임시로 만들었습니다
    • 웹소켓 구현되면 삭제할 예정입니다.
  • 채팅 메시지 조회 API
    • 채팅방 아이디에 따라 최신순으로 조회

💫 작업 요약

  • mongoDB 세팅
  • 채팅방 메시지 조회 API

🔍 중점적으로 리뷰 할 부분

  • yml 파일 수정해서 노션에 업데이트 했습니다!

@hyun2371
[chore] : MongoDB 의존성 추가
fadd896
@hyun2371
[chore] : docker-compose에 mongo 이미지 추가
e85866b
@hyun2371
[feat] : messageType 변환 예외 구체화
16e5caa
@hyun2371
[feat] : chatMessage 엔티티 -> 몽고 DB collection으로 변경
c3702bb
@hyun2371
[feat] : 채팅 메시지 요청 dto 추가
393128e
@hyun2371
[feat] : 채팅 메시지 응답 dto 추가
c167ce8
@hyun2371
[feat] : 채팅 메시지<-> dto mapper 추가
2447b6e
@hyun2371
[feat] : 채팅 메시지 mongoRepository 추가
7b217b1
@hyun2371
[feat] : 채팅 메시지 저장, 조회 비즈니스 로직 추가
99671ee
@hyun2371
[feat] : 채팅 메시지 저장, 조회 API 로직 추가
dcf5e99
@hyun2371
[feat] : 채팅 메시지 조회 비즈니스 로직 테스트
9052cba
@hyun2371
[test] : 테스트 컨테이너에 MongoDB 컨테이너 추가
9cedbec
@hyun2371
[test] : 채팅방 메시지 조회 통합 테스트 작성
c23fcc1
@hyun2371
[rename] : chatMessage-> chatRoom으로 파일명 수정
f9b573d
@hyun2371
[chore] : PR시 배포 되도록 임시 수정
3913048
@hyun2371 hyun2371 added ✨ feat 기능 추가 ⚙️ chore 환경 세팅 labels Aug 29, 2024
@hyun2371 hyun2371 requested a review from dudxo August 29, 2024 11:59
@hyun2371 hyun2371 self-assigned this Aug 29, 2024
@hyun2371 hyun2371 linked an issue Aug 29, 2024 that may be closed by this pull request
✨ 채팅방 메시지 조회 API #92
Closed
3 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

Code Coverage

Overall Project 83.75% -0.86% 🍏
Files changed 60.53% ❌

File Coverage
ChatMessage.java 100% 🍏
ChatRoomService.java 52.17% -47.83% ❌
MessageType.java 50% -14.58% ❌
ChatRoomController.java 42.86% -57.14% ❌

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

Test Results

20 files  20 suites   12s ⏱️
96 tests 96 ✅ 0 💤 0 ❌
97 runs  97 ✅ 0 💤 0 ❌

Results for commit a0552bf.

♻️ This comment has been updated with latest results.

dudxo
dudxo approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@dudxo dudxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

도커 몽고 DB 설정, 테스트 컨테이너 설정까지 하시느라 힘드셨겠네요ㅜ
수고 많으셨습니다!

src/main/java/com/dnd/gongmuin/chat/domain/ChatMessage.java Show resolved Hide resolved
src/main/java/com/dnd/gongmuin/chat/dto/ChatMessageRequest.java Show resolved Hide resolved
src/main/java/com/dnd/gongmuin/chat/service/ChatMessageService.java Outdated Show resolved Hide resolved
@hyun2371 hyun2371 merged commit 65565f7 into dev Aug 29, 2024
3 checks passed
@hyun2371 hyun2371 deleted the feat/#92/mongo-db-chat-message branch August 30, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudxo dudxo dudxo approved these changes

Assignees

@hyun2371 hyun2371

Labels
⚙️ chore 환경 세팅 ✨ feat 기능 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ 채팅방 메시지 조회 API
2 participants
@hyun2371 @dudxo