Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

또 다른 컴포넌트 구현 및 스토리북 추가... #19

Merged
merged 29 commits into from
Aug 9, 2024

Conversation

froggy1014
Copy link
Collaborator

@froggy1014 froggy1014 commented Aug 8, 2024

PR 타입 ( 하나 이상의 PR 타입을 선택해주세요 )

  • 기능 추가
  • 버그 수정
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트
  • 기타 사소한 수정

변경 사항

다이어로그, 이미지 업로드.. 컴포넌트 구현 및 스토리 북 추가하고 자잘한 작업입니다.

스토리북으로 보실 수 있구요..

실질적인 Props 설정은 실제 페이지 들어가면서 해야할 것 같네요.

@froggy1014 froggy1014 self-assigned this Aug 8, 2024
Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fiesta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 4:53pm

Copy link

github-actions bot commented Aug 8, 2024

💅 스토리북 URL 확인하기 - https://66a939e10fecfdf69816c066-znqggaxnlf.chromatic.com/

Copy link

github-actions bot commented Aug 8, 2024

💅 스토리북 URL 확인하기 - https://66a939e10fecfdf69816c066-gqvgibhrgg.chromatic.com/

@froggy1014 froggy1014 linked an issue Aug 8, 2024 that may be closed by this pull request
Copy link
Member

@punchdrunkard punchdrunkard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요! 구현하시느라 고생 많으셨습니다!

  • 이미지 업로드의 경우 mutipart/formdata 방식 사용할 거라서 (API명세)
    base64 인코딩 없이 File 을 formData에 append 하는 방식으로 구현 하시면 될 것 같습니다.
  • 이미지 업로드 컴�포넌트에 드래그앤드롭으로는 파일이 3개까지 올라가지는데 버튼으로는 하나 추가하면 버튼을 클릭해도 이미지 업로드 창이 안뜨는 것 같습니다!
2024-08-09.6.35.47.mov

리뷰는 항상 그렇듯 가볍게 참고만 해주세요!
항상 감사합니다.

src/app/calendar/page.tsx Outdated Show resolved Hide resolved
src/components/imageUploader/ImageUploader.tsx Outdated Show resolved Hide resolved
src/components/imageUploader/ImageUploader.tsx Outdated Show resolved Hide resolved
src/components/imageUploader/ImageUploader.tsx Outdated Show resolved Hide resolved
src/components/imageUploader/ImageUploader.tsx Outdated Show resolved Hide resolved
src/components/imageUploader/ImageUploader.tsx Outdated Show resolved Hide resolved
src/components/imageUploader/ImageUploader.tsx Outdated Show resolved Hide resolved
src/components/imageUploader/ImageUploader.tsx Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Aug 9, 2024

💅 스토리북 URL 확인하기 - https://66a939e10fecfdf69816c066-hxmnxudxyz.chromatic.com/

Copy link

github-actions bot commented Aug 9, 2024

💅 스토리북 URL 확인하기 - https://66a939e10fecfdf69816c066-oeijhmkanp.chromatic.com/

@froggy1014 froggy1014 merged commit 0021689 into develop Aug 9, 2024
5 of 6 checks passed
@froggy1014 froggy1014 deleted the feature/implements-component branch August 9, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

컴포넌트 구현 및 스토리북 정리
2 participants