Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

유저 유형 타입 별 축제 추천 컴포넌트 구현 #43

Merged
merged 16 commits into from
Sep 3, 2024

Conversation

froggy1014
Copy link
Collaborator

@froggy1014 froggy1014 commented Sep 1, 2024

PR 타입 ( 하나 이상의 PR 타입을 선택해주세요 )

  • 기능 추가
  • 버그 수정
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트
  • 기타 사소한 수정

변경 사항

  1. Branding Color 같은 경우는 secondary~ 이런식으로 클래스이름이 고정되어있는데 동적으로 할당하기 위해 tailwind.config.ts safeList에 추가했습니다.
const RecommendFestivalHeader: FC<Props> = ({ userType }) => {
  return (
    <div className="relative flex w-full justify-between">
        <span className={UserTypeText[userType.userTypeId ?? 1]}>
          {userType.name}
        </span>
    </div>
  );
};
  1. 기존에 구현했던 페스티벌 등록 페이지에서 Controlled, UnControlledInput 한 페이지에 같이 있으면서 re-rendering이 되는 부분이 있었는데, useWatch사용을 위해 Controlled Input은 따로 분리했고, Input 컴포넌트에 memo 를 붙여서 불필요한 리렌더링 없도록했습니다.

  2. 어.. auth.ts에 refreshToken 로직을 넣어놨었는데, 이거 제가 완전 잘 못 사용하고 있는거 같아서 일단 주석처리하고 다른 이슈에서 다루도록하겠습니다.

Copy link

vercel bot commented Sep 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fiesta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 2:45pm

Copy link
Member

@Zero-1016 Zero-1016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 :)

이번 리뷰에서는 질문을 많이 하게 되었네요!

tailwind.config.ts Show resolved Hide resolved
import RecommendFestivalList from "./RecommendFestivalList";

const RecommendFestival = async () => {
const festivals = await getRecommendFestival();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 festival은 tanstack query를 사용하지 않고 호출만 하신 이유가 궁금합니다!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

session 유무에 따라서 조건부 렌더링하려고 생각없이 일단 페칭했던거 같습니다. ㅎㅎ ;;

바로 수정했으요 감사합니다.

@froggy1014 froggy1014 linked an issue Sep 2, 2024 that may be closed by this pull request
@froggy1014 froggy1014 merged commit 31d0c88 into develop Sep 3, 2024
2 checks passed
@froggy1014 froggy1014 deleted the feature/recommend-festival branch September 3, 2024 14:46
@froggy1014 froggy1014 added the enhancement New feature or request label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] Profile Recommend Festival
3 participants