Fixes issue with copy module when inherit permissions is unchecked #6459
Conversation
When a user with edit rights (aka admin, NOT host) copies an existing module that has "inherit permissions" unchecked, no permissions are saved for the new module. For the admin user the module "vanishes" from the page (seems to be not added). However the host user still sees the module. fix issue dnnsoftware#5633
When a user with edit rights (aka admin, NOT host) copies an existing module that has "inherit permissions" unchecked, no permissions are saved for the new module. For the admin user the module "vanishes" from the page (seems to be not added). However the host user still sees the module. line 957 fix issue dnnsoftware#5633
When a user with edit rights (aka admin, NOT host) copies an existing module that has "inherit permissions" unchecked, no permissions are saved for the new module. For the admin user the module "vanishes" from the page (seems to be not added). However the host user still sees the module. line 688 fix issue dnnsoftware#5633
When a user with edit rights (aka admin, NOT host) copies an existing module that has "inherit permissions" unchecked, no permissions are saved for the new module. For the admin user the module "vanishes" from the page (seems to be not added). However the host user still sees the module. line 688 fix issue dnnsoftware#5633
valadas
changed the title
| newModule.PortalID = PortalSettings.Current.PortalId; | ||
| ModulePermissionController.SaveModulePermissions(newModule); | ||
| } | ||
| else |
There was a problem hiding this comment.
The if of this else has logic to set view permissions if remote is true, just thinking here if maybe we should just remove that condition would be the bug fix. Because now if the copy is on the same site it will copy all permissions (which users might not be expecting to happen). I think if at least the admin sees the module it would be good enough to fix the reported issue IMO.
There was a problem hiding this comment.
I get what you are saying, but I would see this as 'unexpected', module permissions are a deliberate act by the content manager, so IMO keeping the permissions while copying the module to another section on the site would be logical.
That being said, your suggestion solves the current bug...
Fixes #5633
Summary
When a user with edit rights (aka admin, NOT host) copies an existing module that has "inherit permissions" unchecked, no permissions are saved for the new module.
For the admin user the module "vanishes" from the page (seems to be not added). However the host user still sees the module.
reverted line 957 in ModuleInfo.cs and added code starting on line 688 in ControlBarController.cs
fix issue #5633