feat: vm scheduler #10
Conversation
WoodenMaiden
force-pushed
the
9-vm-scheduler
branch
3 times, most recently
from
5bdcb96 to
556168e
Compare
Signed-off-by: WoodenMaiden <[email protected]>
WoodenMaiden
force-pushed
the
9-vm-scheduler
branch
from
556168e to
8c73b39
Compare
WoodenMaiden
force-pushed
the
9-vm-scheduler
branch
from
6e92726 to
dfffa79
Compare
WoodenMaiden
requested review from
alexis-langlet and
nponsard
and removed request for
alexis-langlet
|
|
||
| if returnedCursor != 0 { | ||
| // the current sweep did not find anything, we try again | ||
| return s.LookForReadyInstance(functionId, returnedCursor) |
There was a problem hiding this comment.
Is there a reason why this is recursive?
There was a problem hiding this comment.
Basically in Redis, SCAN allows you to get keys matching a certain pattern just like KEYS would.
While KEYS locks the DB and scans everything in one shot, SCAN gets x keys and returns a cursor, you can then use the returned cursor to your next SCAN call to continue scanning until the returned cursor is 0.
This is why it is recursive, I can refactor it into interative if you want.
There was a problem hiding this comment.
Okay I understand
You don't need to put that in an iterative way but if could just add some comments in your code to say what you just explained it would be really nice
scheduler/scheduler.go
Outdated
|
|
||
|
|
||
| // because while does not exists in these lands | ||
| for ok, cursor := true, uint64(0) ; ok; ok = (cursor != 0) { |
There was a problem hiding this comment.
maybe using a for true { if (...) break } would be more understandable ;)
There was a problem hiding this comment.
Yeah I don't understand this line, feels like it could be simpler.
scheduler/scheduler.go
Outdated
|
|
||
|
|
||
| // because while does not exists in these lands | ||
| for ok, cursor := true, uint64(0) ; ok; ok = (cursor != 0) { |
There was a problem hiding this comment.
Yeah I don't understand this line, feels like it could be simpler.
main.go
Outdated
| } | ||
| //Now inject the scheduler into the routes that need it! | ||
|
|
||
| err := cronjob.AddFunc("0 */6 * * *", func() { s.FindAndDestroyUnsused() }) |
There was a problem hiding this comment.
Do we really need a library to do this ?
Sounds like it could be a loop with a sleep in a separate thread (using the go keyword)
scheduler/scheduler.go
Outdated
| return | ||
| } | ||
|
|
||
| func (s *Scheduler) FindAndDestroyUnsused() { |
There was a problem hiding this comment.
It would be good to have a comment explaining what this do
WoodenMaiden
force-pushed
the
9-vm-scheduler
branch
from
dfffa79 to
3977be1
Compare
Resolves #9