Testcase and workaround for Issue 432 - two other test cases are affected #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I took a different approach, fixing the underlying metadata parser to handle units. I sort of knew I wasn't doing that, but I didn't have a test image that used units and hadn't got around to manufacturing one. One point for the future: your editing tool is making a lot of irrelevant changes in whitespace. That makes the diff quite difficult to read. If it's possible, it would be nice to avoid that. |
|
Sure, my change was only a workaround,I couldn't even find the sources for the metadata parser. Whitespace: I am using Oxygen as XML Editor. I will do my very best to avoid whitespace changes in the future.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution is mainly for the new testcase mediaobject.006 where SVG image dimensions are given in inch.
The real cause is a problem with the external function
ext:image-metadatawhich ignores width and height when given as value with a unit.A workaround for Issue 432 is included, so that scaling of an SVG Image where dimensions have units seems to be correct. This affects two other testcases: calloutlist.004 and calloutlist.005. For both the tests will fail, because the created result does not meet expectations. But the dimensions of the generated images are unchanged, so i would think that the generated results are still correct.