Prevent crash in case of multiple entries in glossary. Changed description of glossary-collection #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption of glossary-collection. When there were more than one entries for a glossterm, a warning was emitted and than the transformation failed with a runtime error. This was changed so that only the first of many entries will be referenced. Testcase glossary.001 was extended and will cover two entries for one term Pepper. The description for glossary-collection was changed. It suggested the necessity for a lot of empty glossentries which must match external entries by xml:id. Seems to be pretty easy, see test glossary.002. - just create an empty glossary with role='auto'. That's all - we dont need @xml:id in glossentries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are more than one entries for a glossterm, a warning was emitted and than the transformation failed with a runtime error. This was changed so that only the first of many entries will be referenced. Testcase glossary.001 was extended and will cover two entries for one term (Pepper).
The description for glossary-collection was changed. It suggested the necessity for a lot of empty glossentries which must match external entries by xml:id. It is not that difficult. In fact, it seems to be pretty easy, see test glossary.002 and the new description.