-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update php/variant-fpm.md #2559
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, although I'd rather use plain apostrophes than fancy ones for these docs 👍
(I do wish more of the content from https://php-fpm.org/ moved to the PHP docs since it's interesting/useful background, but it's totally fair to make users find it instead of linking to it directly) |
Co-authored-by: Tianon Gravi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you!
Sure. Just a habit, because they are just too conveniently available on my Linux keyboard layer 3 😁 |
I just looked through that and didn't see anything particularly interesting. Anything you are specifically interested in? Given there is php/php-src#18217, perhaps add a short comment of what you would like to see moved to the official docs. |
I meant more of the superfluous overview stuff, like that bulleted list right on the homepage. It's all very arguably "useless" information now that FPM is merged upstream (because it's information that probably helped convince folks it should go upstream, as opposed to meaningful information for people choosing/running it now). |
Some opinionated suggestions.
Fixes #2558