Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update php/variant-fpm.md #2559

Merged
merged 2 commits into from
Apr 2, 2025
Merged

Update php/variant-fpm.md #2559

merged 2 commits into from
Apr 2, 2025

Conversation

TimWolla
Copy link
Contributor

@TimWolla TimWolla commented Apr 1, 2025

Some opinionated suggestions.

Fixes #2558

Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, although I'd rather use plain apostrophes than fancy ones for these docs 👍

@tianon
Copy link
Member

tianon commented Apr 1, 2025

(I do wish more of the content from https://php-fpm.org/ moved to the PHP docs since it's interesting/useful background, but it's totally fair to make users find it instead of linking to it directly)

Co-authored-by: Tianon Gravi <[email protected]>
Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@TimWolla
Copy link
Contributor Author

TimWolla commented Apr 1, 2025

although I'd rather use plain apostrophes than fancy ones for these docs 👍

Sure. Just a habit, because they are just too conveniently available on my Linux keyboard layer 3 😁

@TimWolla
Copy link
Contributor Author

TimWolla commented Apr 1, 2025

(I do wish more of the content from https://php-fpm.org/ moved to the PHP docs since it's interesting/useful background, but it's totally fair to make users find it instead of linking to it directly)

I just looked through that and didn't see anything particularly interesting. Anything you are specifically interested in? Given there is php/php-src#18217, perhaps add a short comment of what you would like to see moved to the official docs.

@tianon
Copy link
Member

tianon commented Apr 2, 2025

I meant more of the superfluous overview stuff, like that bulleted list right on the homepage. It's all very arguably "useless" information now that FPM is merged upstream (because it's information that probably helped convince folks it should go upstream, as opposed to meaningful information for people choosing/running it now).

@tianon tianon merged commit 6823e87 into docker-library:master Apr 2, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

php/variant-fpm.md refers to non-official resources
2 participants