Skip to content

Update Git for Windows to 2.48.1 #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

tianon
Copy link
Member

@tianon tianon commented Feb 14, 2025

It's been a while since we updated this, we probably should (and maybe more often; perhaps automated). 🙈

@tianon
Copy link
Member Author

tianon commented Feb 14, 2025

Of course, quite notably, I'm not comfortable merging this right now thanks to docker-library/official-images#18435 (comment):

The problem is that the windows-2025 runner is too old to run the mcr.microsoft.com/windows/servercore:ltsc2025 image released this week (actions/runner-images#11582).

🙃 😭

@tianon tianon marked this pull request as draft February 14, 2025 00:18
@tianon
Copy link
Member Author

tianon commented Feb 14, 2025

perhaps automated

If we use our current automation, this will be updated without being tested (because testing Windows is a blind-spot in our current automation until it pushes the commit and GitHub does a test).

@yosifkit
Copy link
Member

yosifkit commented Mar 3, 2025

Close/open to retrigger GitHub Actions now that actions/runner-images#11582 is resolved

@yosifkit yosifkit closed this Mar 3, 2025
@yosifkit yosifkit reopened this Mar 3, 2025
@yosifkit
Copy link
Member

perhaps automated

If we use our current automation, this will be updated without being tested (because testing Windows is a blind-spot in our current automation until it pushes the commit and GitHub does a test).

Yeah, until we include Windows tests in our automated update.sh job we should not do it there. Maybe automated PRs to have GHA run the test builds. Perhaps that would just be the git updates and not replace the auto-committed go version bumps of the update.sh job.

@tianon tianon marked this pull request as ready for review March 13, 2025 00:44
@tianon tianon merged commit 0f7ef09 into docker-library:master Mar 13, 2025
31 of 32 checks passed
@tianon tianon deleted the git-for-windows branch March 13, 2025 00:45
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Mar 13, 2025
Changes:

- docker-library/golang@0f7ef09: Merge pull request docker-library/golang#553 from infosiftr/git-for-windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants