Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update github.com/spf13/cobra to 1.7.0 #51

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

crazy-max
Copy link
Member

follow-up #14 (comment)

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1a3957) 67.36% compared to head (3912827) 69.44%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   67.36%   69.44%   +2.08%     
==========================================
  Files           4        4              
  Lines         576      432     -144     
==========================================
- Hits          388      300      -88     
+ Misses        132       76      -56     
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crazy-max crazy-max force-pushed the bump-cobra branch 2 times, most recently from ea3c931 to 014a7c2 Compare February 22, 2024 11:56
@thaJeztah
Copy link
Member

Something's failing because go.sum doesn't match;

Error: main.go:21:2: missing go.sum entry for module providing package github.com/docker/buildx/commands; to add:
	go mod download github.com/docker/buildx
Error: main.go:29:2: missing go.sum entry for module providing package github.com/docker/buildx/driver/docker; to add:
	go mod download github.com/docker/buildx
Error: main.go:30:2: missing go.sum entry for module providing package github.com/docker/buildx/driver/docker-container; to add:
	go mod download github.com/docker/buildx
Error: main.go:31:2: missing go.sum entry for module providing package github.com/docker/buildx/driver/kubernetes; to add:
	go mod download github.com/docker/buildx
Error: main.go:23:2: missing go.sum entry for module providing package github.com/docker/cli/cli/command; to add:
	go mod download github.com/docker/cli
Error: Process completed with exit code 1.

@crazy-max
Copy link
Member Author

Bumping to 1.6.1 and trying to align buildx version for example looks broken so bumped to 1.7.0 instead. I think that's fine, don't think we are gonna bump cli-docs-tool on Docker 23 anyway 😅.

@crazy-max crazy-max changed the title vendor: update github.com/spf13/cobra to 1.6.1 vendor: update github.com/spf13/cobra to 1.7.0 Feb 22, 2024
also align buildx version

Signed-off-by: CrazyMax <[email protected]>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM works for me. I guess the alternative could've been to keep the main module on 1.6, but the examples at 1.7, but meh

@thaJeztah thaJeztah merged commit 4b6fbdb into docker:main Feb 22, 2024
3 checks passed
@crazy-max crazy-max deleted the bump-cobra branch February 22, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants