cli/command, cil/command/image: remove deprecated methods and functions

[thaJeztah]

• relates to / depends on cli/command: internalize and deprecate Cli.NotaryClient #5885
• relates to / depends on cli/command: deprecate Cli.ManifestStore, Cli.RegistryClient #5889
• relates to / depends on move cli-plugins metadata types/consts to a separate package #5902
• relates to / depends on move some trust-related code to trust package #5894
• relates to vendor: github.com/docker/cli buildx#3033

cli/command: remove deprecated NotaryClient from CLI interface

This method is a shallow wrapper around trust.GetNotaryRepository, but
due to its signature resulted in the trust package, and notary dependencies
to become a dependency of the CLI. Consequence of this was that cli-plugins,
which need the cli/command package, would also get notary and its
dependencies as a dependency. It is no longer used, and was deprecated
in 9bc16bb.

This patch removes the NotaryClient method from the interface

cli/command: remove deprecated ManifestStore from CLI interface

This method is a shallow wrapper around manifeststore.NewStore, but
due to its signature resulted in various dependencies becoming a dependency
of the "command" package. Consequence of this was that cli-plugins, which
need the cli/command package, would also get those dependencies. It is no
longer used, and was deprecated in e32d5d5.

This patch removes the ManifestStore method from the interface

cli/command: remove deprecated RegistryClient from CLI interface

This method was a shallow wrapper around registryclient.NewRegistryClient but
due to its signature resulted in various dependencies becoming a dependency
of the "command" package. Consequence of this was that cli-plugins, which
need the cli/command package, would also get those dependencies. It is no
longer used, and was deprecated in 8ad0721.

This patch removes the RegistryClient method from the interface

cli/command/image: remove deprecated TrustedPush

This function was only used by "docker trust sign", and has no known external
consumers. It was deprecated in c6f456b;
this commit removes it.

cli/command/image: remove deprecated PushTrustedReference

This function was only used internally, and has no known external consumers.
It was deprecated in d804360; this commit
removes it.

cli/command/image: remove deprecated TagTrusted

This function was only used internally, and has no known external consumers.
It was deprecated in e37d814; this commit
removes it.

- Human readable description for the release notes

Go-SDK: `cli/command/image`: remove deprecated `TrustedPush`, `TagTrusted`, and `PushTrustedReference` functions.
Go-SDK: `cli/command`: remove deprecated `NotaryClient` and `ManifestStore`, and `RegistryClient` from CLI interface.

- A picture of a cute animal (not mandatory but encouraged)

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.46%. Comparing base (e002576) to head (4541df2).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5876      +/-   ##
==========================================
+ Coverage   59.42%   59.46%   +0.04%     
==========================================
  Files         358      357       -1     
  Lines       29768    29747      -21     
==========================================
  Hits        17690    17690              
+ Misses      11113    11092      -21     
  Partials      965      965              

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[thaJeztah]

This is a difference; before this, we would take the Err() output from the CLI, and now we switched to the Cobra cmd's StdErr() - we should look in our code altogether to consider using that (instead of depending on the DockerCLI to provide us the stderr/stdout; I think they're coupled either way.

[tianon]

Surprising nobody (and I'm not a maintainer here, so FWIW), this LGTM 😇

[thaJeztah]

Thanks both! I'll wait for others to have a last look Tomorrow before merging, but looks like we can go ahead.

For others visiting this PR; removing these methods technically is a "breaking" change, so would require a major version update.

However, the cli/command package was never really designed as a public API, and gained features and functions that were ultimately for "internal use".

The features removed here specifically were intended for internal use in the CLI itself, and not for external consumers, but had a big impact on every (cli-plugin) user that used the docker/cli as dependency.

I did a search through public repositories, and could not find any consumer of these functions (and I would not expect any user of out code to actually be using these), so removing these should very unlikely impact any user of the code, other than in a "positive" way of many (indirect) dependencies being removed 🎉