Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade: 清理和升级依赖 #396

Merged
merged 26 commits into from
Nov 18, 2024

Conversation

starknt
Copy link
Contributor

@starknt starknt commented Nov 15, 2024

Ⅰ. 描述此PR的作用:

作为PR #391 的第二部分

TODO:

  • eslint
  • 更多的组件升级
  • 测试

Ⅱ. 此PR修复了哪个issue吗?

fixes #390

Ⅲ. 界面变化截屏

@wangliang181230 wangliang181230 marked this pull request as draft November 16, 2024 12:32
@wangliang181230 wangliang181230 marked this pull request as draft November 16, 2024 12:32
@wangliang181230
Copy link
Contributor

wangliang181230 commented Nov 16, 2024

我先把这个PR转成 draft 了,你好了以后,转成 open ,我再过来测试下。

@wangliang181230
Copy link
Contributor

原来 coremitmproxy 还可以互相依赖的啊,厉害了。

@starknt
Copy link
Contributor Author

starknt commented Nov 16, 2024

只在dev的时候依赖

@starknt starknt marked this pull request as ready for review November 18, 2024 03:47
@starknt starknt marked this pull request as draft November 18, 2024 03:55
@starknt starknt marked this pull request as ready for review November 18, 2024 04:24
@wangliang181230
Copy link
Contributor

已经好了吗?那我晚上去测试下。 ^_^

@wangliang181230
Copy link
Contributor

@starknt 能配置 elsecatch 之类的不换行吗?看着好不习惯。

@starknt
Copy link
Contributor Author

starknt commented Nov 18, 2024

else 不换行?

if(c) {
	// do something
} else { // do something ? 这样? }

@wangliang181230
Copy link
Contributor

else 不换行?

if(c) {
	// do something
} else { // do something ? 这样? }

这样:

if (c) {
    // do something
} else {
    // do something 
}

而不是:

if (c) {
    // do something
}
else {
    // do something 
}

@wangliang181230
Copy link
Contributor

wangliang181230 commented Nov 18, 2024

就是 } 后面跟着 elsecatch 等,不换行。

@starknt
Copy link
Contributor Author

starknt commented Nov 18, 2024

应该可以配置

@wangliang181230
Copy link
Contributor

cli 模块,是预留着开发命令行工具是吗?

@starknt
Copy link
Contributor Author

starknt commented Nov 18, 2024

问题1:Ubuntu 系统,执行 npm run electron 运行程序报错:

[2268:1118/070314.633093:ERROR:ozone_platform_x11.cc(247)] Missing X server or $DISPLAY
[2268:1118/070314.633137:ERROR:env.cc(226)] The platform failed to initialize.  Exiting.

点击查看截图和详细日志

没有安装 x11 当然报错了

@wangliang181230
Copy link
Contributor

问题1:Ubuntu 系统,执行 npm run electron 运行程序报错:

[2268:1118/070314.633093:ERROR:ozone_platform_x11.cc(247)] Missing X server or $DISPLAY
[2268:1118/070314.633137:ERROR:env.cc(226)] The platform failed to initialize.  Exiting.

点击查看截图和详细日志

没有安装 x11 当然报错了

噢,好吧。哈哈。

@wangliang181230
Copy link
Contributor

wangliang181230 commented Nov 18, 2024

问题2:dns.lookup 失败:

[2024-11-18T16:03:39.480] [ERROR] server - [DNS] cannot resolve hostname img.shields.io, error:
TypeError: invalid size value (must be positive integer). When maxSize or maxEntrySize is used, sizeCalculation or size must be set.
    at LRUCache.requireSize (webpack://@docmirror/dev-sidecar-gui/../../node_modules/.pnpm/[email protected]/node_modules/lru-cache/index.js?:420:17)
    at LRUCache.set (webpack://@docmirror/dev-sidecar-gui/../../node_modules/.pnpm/[email protected]/node_modules/lru-cache/index.js?:671:17)
    at DNSOverHTTPS.lookup (webpack://@docmirror/dev-sidecar-gui/../mitmproxy/src/lib/dns/base.js?:48:20)
    at eval (webpack://@docmirror/dev-sidecar-gui/../mitmproxy/src/lib/proxy/mitmproxy/dnsLookup.js?:24:11)
    at node:net:1052:5
    at defaultTriggerAsyncIdScope (node:internal/async_hooks:465:18)
    at lookupAndConnect (node:net:1051:3)
    at Socket.connect (node:net:989:5)
    at Object.connect (node:net:203:17)
    at connect (webpack://@docmirror/dev-sidecar-gui/../mitmproxy/src/lib/proxy/mitmproxy/createConnectHandler.js?:117:29)

详细运行日志:
https://github.com/docmirror/dev-sidecar/actions/runs/11896273956/job/33147798441

@starknt
Copy link
Contributor Author

starknt commented Nov 18, 2024

这个 lru-cache 升级的问题太多了

@wangliang181230
Copy link
Contributor

这个 lru-cache 升级的问题太多了

是啊,好几次这东西报错了。

@wangliang181230
Copy link
Contributor

现在好像没问题了,我再自己 PC 安装测试一下看看。

# Conflicts:
#	README.md
#	packages/cli/src/index.js
#	packages/core/src/modules/server/index.js
#	packages/gui/src/bridge/update/front.js
#	packages/gui/src/view/App.vue
#	packages/gui/vue.config.js
#	packages/mitmproxy/src/lib/proxy/middleware/overwall.js
#	packages/mitmproxy/src/lib/proxy/tls/FakeServersCenter.js
@wangliang181230 wangliang181230 merged commit ce6e73d into docmirror:master Nov 18, 2024
3 checks passed
wangliang181230 added a commit to wangliang181230/dev-sidecar that referenced this pull request Nov 18, 2024
@wangliang181230
Copy link
Contributor

测试通过啦!!!

@wangliang181230 wangliang181230 added the v2.0.0 2.0.0版本 label Nov 18, 2024
@wangliang181230
Copy link
Contributor

问题1:Ubuntu 系统,执行 npm run electron 运行程序报错:

[2268:1118/070314.633093:ERROR:ozone_platform_x11.cc(247)] Missing X server or $DISPLAY
[2268:1118/070314.633137:ERROR:env.cc(226)] The platform failed to initialize.  Exiting.

点击查看截图和详细日志

没有安装 x11 当然报错了

x11 怎么安装啊?百度了下,好多条命令,不知道是哪条命令。
图片

@starknt
Copy link
Contributor Author

starknt commented Nov 21, 2024

@wangliang181230
Copy link
Contributor

好的,我去看下。

@wangliang181230 wangliang181230 added the Upgrade 包括框架升级、依赖版本升级等 label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Upgrade 包括框架升级、依赖版本升级等 v2.0.0 2.0.0版本
Projects
None yet
2 participants