Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI/logo+nav #126

Closed
wants to merge 16 commits into from
Closed

UI/logo+nav #126

wants to merge 16 commits into from

Conversation

osala-eng
Copy link
Contributor

@osala-eng osala-eng commented Oct 12, 2023 •
edited by janaka
Loading

Description

Fixes/Implements #103

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor and code improvement (non-breaking change which improves code quality and/or performance)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation
  • Tests
  • Other chores such as maintenance

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration by modifying the list below.

  • Test A
  • Test B
  • Test C

Test Configuration:

Please describe the test setup. List them below as bullet points.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • The commit message follows the convention of this project

@janaka janaka linked an issue Oct 15, 2023 that may be closed by this pull request
UI/UX[RFC]: system to enable a header bar and controlling side bar render order #103
Closed
janaka
janaka reviewed Oct 16, 2023
View reviewed changes
web/utils/sessions.py Outdated
@@ -125,6 +129,9 @@ def get_selected_org_id() -> int | None:
def set_selected_org_id(org_id: int) -> None:
"""Set the selected org_id context."""
_set_session_value(org_id, SessionKeySubName.AUTH, SessionKeyNameForAuth.SELECTED_ORG_ID.name)
set_cache_auth_session(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this so that the selected org persists refreshes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should have cache mutation happening in these session functions.

@osala-eng osala-eng closed this Nov 23, 2023
@osala-eng osala-eng deleted the ui/logo+nav branch November 23, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janaka janaka janaka left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI/UX[RFC]: system to enable a header bar and controlling side bar render order
2 participants
@osala-eng @janaka