Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove ask "your" documents feat. #168

Merged
merged 8 commits into from
Nov 30, 2023
Merged

refactor: remove ask "your" documents feat. #168

merged 8 commits into from
Nov 30, 2023

Conversation

janaka
Copy link
Contributor

@janaka janaka commented Nov 30, 2023

Description

Last PR to complete #102

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor and code improvement (non-breaking change which improves code quality and/or performance)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation
  • Tests
  • Other chores such as maintenance

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration by modifying the list below.

  • Test A
  • Test B
  • Test C

Test Configuration:

Please describe the test setup. List them below as bullet points.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • The commit message follows the convention of this project

@janaka
refactor: personal ask UI and query functions removed
be515ac
@janaka
save
1658d7d
@janaka
refactor: remove more personal ask code
04a1051
@janaka
test: fix tests after removing personal ask
f20c72e 
also remove personal ask tests.
@janaka
refactor: page title and favicon render logic
056ce05 
- add Docq.AI logo as favicon
- remove underscores from page titles
- `about`menu content avail on every page.
- fix: `about` menu content not rendering
- fix: `about` menu content formatting
@janaka
bump version to 0.7.0
e9c76e1
@janaka
fix(ML Tools): remove extractors since Llama Index 0.9.x upgrade
a9956bc
@janaka
fix
e640ef0
@janaka janaka requested a review from a team as a code owner November 30, 2023 15:11
@janaka janaka mentioned this pull request Nov 30, 2023
Closed
@janaka janaka linked an issue Nov 30, 2023 that may be closed by this pull request
CORE/UX: consolidate Personal ASK into the org structure #102
Closed
@janaka janaka merged commit 2e577dd into main Nov 30, 2023
1 check passed
@janaka janaka deleted the remove-ask-your-documents-feat branch November 30, 2023 15:21
osala-eng pushed a commit that referenced this pull request Dec 1, 2023
@janaka @osala-eng
refactor: remove ask "your" documents feat. (#168)
7a5420b 
* refactor: personal ask UI removed
* refactor: remove more personal ask code
* test: fix tests after removing personal ask also remove personal ask tests.

Other: 
* refactor: page title and favicon render logic
  - add Docq.AI logo as favicon
  - remove underscores from page titles
  - `about` menu content avail on every page.
  - fix: `about` menu content not rendering
  - fix: `about` menu content formatting

* bump version to 0.7.0

* fix(ML Tools): remove extractors since Llama Index 0.9.x upgrade
osala-eng pushed a commit that referenced this pull request Dec 1, 2023
@janaka @osala-eng
refactor: remove ask "your" documents feat. (#168)
c6797e9 
* refactor: personal ask UI removed
* refactor: remove more personal ask code
* test: fix tests after removing personal ask also remove personal ask tests.

Other: 
* refactor: page title and favicon render logic
  - add Docq.AI logo as favicon
  - remove underscores from page titles
  - `about` menu content avail on every page.
  - fix: `about` menu content not rendering
  - fix: `about` menu content formatting

* bump version to 0.7.0

* fix(ML Tools): remove extractors since Llama Index 0.9.x upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CORE/UX: consolidate Personal ASK into the org structure
1 participant
@janaka