Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove countable word #222

Closed
wants to merge 1 commit into from
Closed

Remove countable word #222

wants to merge 1 commit into from

Conversation

driesvints
Copy link

The word "environment" is countable. Please see #216 (comment)

The word "environment" is countable.
@driesvints
Copy link
Author

The failing CI check is failing on 2.0.x as well.

@greg0ire greg0ire added the Bug label Jun 16, 2023
@greg0ire
Copy link
Member

I'd love to have your input on #221 as well.

@EilifAkerjordet
Copy link

I would like to add that the same goes for the word "permission" - I see more words as well in #216 that are countable

@greg0ire
Copy link
Member

greg0ire commented Jun 16, 2023

When talking about "the environment" (as in 🌳 ), I think it's uncountable. But when talking about "an environment" it isn't, and in our jobs, it's more likely we are going to talk about the latter, so it seems fair to revert this. Should we revert other words as well, such as "permission"? Also, is there something we can do to prevent them from being added again? IIRC it's possible to add tests for this.

@driesvints driesvints closed this Jun 16, 2023
@driesvints driesvints deleted the patch-1 branch June 16, 2023 13:32
@driesvints
Copy link
Author

Closing this as I don't think reverting just one word is the right approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants