Commands throw exception if ran twice. #1195
Open
+38
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warxcell
force-pushed
the
execute_command_twice_error
branch
from
373d56f
to
4df30e7
Compare
Warxcell
changed the title
goetas
reviewed
Aug 24, 2021
| $commandTester = new CommandTester($command); | ||
|
|
||
| // execute once, this will freeze the dependencies. | ||
| $commandTester->execute( |
There was a problem hiding this comment.
im not sure if this test makes sense... is it possible to execute two times the same command ? ( i guess that you are using it as a service, not CLI, right?)
There was a problem hiding this comment.
Yes, commands are ran from PHPUnit without going a loop throught CLI and bootstraping the project again. Basically services are instantiated, and second ran of command uses same services, and one of them (DependencyFactory) is frozen and throws exception on second ran.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hello, we a project which is using two databases, and we have tests that runs
doctrine:migrations:migratefor each test.We run commands without going out of the framework.The problem is that basically commands can be ran only single time, otherwise they throw exception. (I added test case for that).
I'm not sure how to solve that, so I accept help. :)