Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update message of ORMInvalidArgumentException #11845

Open
wants to merge 2 commits into
base: 2.20.x
Choose a base branch
from
Open

Update message of ORMInvalidArgumentException #11845

wants to merge 2 commits into from

Conversation

lacatoire
Copy link

update message to use attribute instead of annotation

@lacatoire
Update ORMInvalidArgumentException.php
3aed691 
update message to use attribute instead of annotation
@derrabus derrabus added this to the 2.20.3 milestone Feb 21, 2025
@derrabus derrabus changed the title Update ORMInvalidArgumentException.php Update message of ORMInvalidArgumentException Feb 21, 2025
derrabus
derrabus requested changes Feb 21, 2025
View reviewed changes
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to escape the quotes in the exception message.

@lacatoire
Copy link
Author

Escaped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
2.20.3
Development

Successfully merging this pull request may close these issues.
2 participants
@lacatoire @derrabus