Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifies value assignment #155

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fabiojaniolima
Copy link

This bulk assignment approach avoids typing errors. If the property exists the value will be assigned.

Copy link

@amims71 amims71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about checking if the $data array has any value out of the if-else list? could be a security bridge!

@fabiojaniolima
Copy link
Author

@amims71

I understand. I had thought of it this way to make the input more dynamic.

I added a list of allowed inputs in my last comia.

@fabiojaniolima
Copy link
Author

@amims71 I admit I didn't understand why Travis.ci failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants