-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper-case primitive from DocuSign API causes fatal error #41
Conversation
Proper-case primitive returned from DocuSign API causes fatal error ``` Fatal Error (1): Class 'Number' not found in [/path/to/app/vendor/docusign/esign-client/src/ObjectSerializer.php, line 274] ``` Also fixed the call to `santitizeFilename` not being called via instance or static call at line 261 by setting method to static and calling staticly.
Fixed `$class` needing to be lowercase for primitive values
Oh nice, this probably makes my PR unnecessary: #46 |
* PHP doesn't have a `void` type and uses `null` instead. Changed the type to be "null" * Since "Number" isn't a valid primitive and is handled by a class, removed it from the list of primitives
Number and Date type received and aren't handled when deserializing properly causing fatal errors ``` Fatal Error (1): Class 'Number' not found ```
We also have these problems and they are a show stopper for us. Can these changes please be accepted, merged and released? Thanks in advance! |
Could we get a response on these pull requests? There are some that have been open since 2016. |
Added new configuration option for #57 |
@trickeyone Why are there seemingly unrelated changes here - like SSL changes? Might be a reason why this hasn't been merged yet. |
@gsnavin can you help merge this please? Thanks |
@ccorliss @gsnavin Any update on this? This is a major blocker due to errors like this:
|
So, it's been almost another year. Can we get an update on if this is going to be merged into 4.x or 5.x? |
# Conflicts: # src/ApiClient.php
Closing in favor of updated #180 since this PR is well over 5 years old. Hoping the new PR with a single change will be merged to correct this issue. |
Proper-case primitive returned from DocuSign API causes fatal error
Also fixed the call to
santitizeFilename
not being called via instance or static call at line 261 by setting method to static and calling staticly.