과제 완료 - 한슬희 #7
Open
과제 완료 - 한슬희 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyesungoh
reviewed
Apr 14, 2022
|
|
||
| function App() { | ||
| const [number, setNumber] = useState(0); | ||
| const EVEN = "even"; | ||
| const ODD = "odd"; |
There was a problem hiding this comment.
이런 상수 (constant)는 컴포넌트 외부에서 관리하는 게 좋을 거 같아요!
| const [number, setNumber] = useState(0); | ||
| const EVEN = "even"; | ||
| const ODD = "odd"; | ||
| const title = document.querySelector(".numText"); |
There was a problem hiding this comment.
말씀해주신 것처럼 useRef를 사용해보는 방향으로 하는게 좀 더 react스러울 거 같아요~~
| title?.classList.add(EVEN); | ||
| } else { | ||
| title?.classList.remove(EVEN); | ||
| title?.classList.add(ODD); |
There was a problem hiding this comment.
현재 작성해주신 내용이 유지보수 측면에서 이점도 있고, 가독성도 좋다고 생각해요! 근데 더 축약할 수 있는 방법에 대해 말씀드리자면
className 초기 상태를 설정 후,
useEffect(() => {
title?.classList.toggle(ODD);
title?.classList.toggle(EVEN);
}, [number]);이렇게도 할 수 있을 거 같아요~~~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useRef가 뒤늦게 생각이나 후에 다시 커밋해보겠슴니다. ㅠ