Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.7.10, 1.12.2... Crash on load #83

Closed
xJon opened this issue Mar 16, 2024 · 25 comments
Closed

1.7.10, 1.12.2... Crash on load #83

xJon opened this issue Mar 16, 2024 · 25 comments
Assignees
Labels
bug Something isn't working

Comments

@xJon
Copy link

xJon commented Mar 16, 2024

First reported over xJon/Hexxit-II#230:
javax.net.ssl.SSLHandshakeException: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
https://mclo.gs/d7kVwP0#L71

This is using version 1.5, and has been reported by players who ran the modpack and mod before.

@EvaLinn
Copy link

EvaLinn commented Mar 16, 2024

I have the same problem, Minecraft version 1.12.2, Mod version 1.3

@EvaLinn
Copy link

EvaLinn commented Mar 16, 2024

serializationisbad.json
I put this file into config folder, it works

@spadethrills
Copy link

serializationisbad.json I put this file into config folder, it works

Confirmed it works for me too. Thanks Eva

@dogboy21
Copy link
Owner

dogboy21 commented Mar 16, 2024

It looks like Github changed their SSL certificate on the raw.githubusercontent.com domain to a new one which isn't trusted in very old Java versions (8u51 in this case).

SiB downloads its config from there if there isn't one locally in the config directory:

  • either serializationisbad.json
  • (Versions >= 1.5) or the serializationisbad-remotecache.json which gets created after a successful download from Github

I'm currently looking for another reliable static file host where I can upload the config file to, which also has a certificate that is trusted by ancient Java versions.

In the meantime, like @EvaLinn already mentioned, adding the file manually to the config directory works as a workaround.

EDIT: Currently evaluating if Cloudflare R2 would be a viable option, but due to maintenance on their end, that may take a bit of time

@dogboy21 dogboy21 pinned this issue Mar 16, 2024
dogboy21 added a commit that referenced this issue Mar 16, 2024
Github replaced their certificate, making it invalid with the CA certs of Java 8u51.
See #83 for details
@dogboy21
Copy link
Owner

I just published version 1.5.1 on Github with a changed URL for the remote config.
Could you please check if that resolves the issue on your end as well?

@dogboy21 dogboy21 added bug Something isn't working awaiting for response awaiting a response from user labels Mar 16, 2024
@dogboy21 dogboy21 self-assigned this Mar 16, 2024
@EvaLinn
Copy link

EvaLinn commented Mar 16, 2024

I just published version 1.5.1 on Github with a changed URL for the remote config. Could you please check if that resolves the issue on your end as well?

I don't think I can check this out. That's not me holding a server. I can change it on my side but I don't think it's gonna work

@dogboy21
Copy link
Owner

I don't think I can check this out. That's not me holding a server. I can change it on my side but I don't think it's gonna work

Updating it only on the client side should work just fine

@EvaLinn
Copy link

EvaLinn commented Mar 16, 2024

I don't think I can check this out. That's not me holding a server. I can change it on my side but I don't think it's gonna work

Updating it only on the client side should work just fine

I deleted that config file and changed to new version and... Nope, it doesn't work

@dogboy21
Copy link
Owner

Could you send me your game log?

@EvaLinn
Copy link

EvaLinn commented Mar 16, 2024

latest.log

@EvaLinn
Copy link

EvaLinn commented Mar 16, 2024

Could you send me your game log?

Lol I noticed, why it says 1.3

@EvaLinn
Copy link

EvaLinn commented Mar 16, 2024

I can't delete the file because my launcher loads it again :( Modpack in TLauncher. You should ask someone else to help XD

@ThePixelbrain
Copy link
Collaborator

I can't delete the file because my launcher loads it again :( Modpack in TLauncher. You should ask someone else to help XD

You should update the SerializationIsBad mod to 1.5.1. If your launcher doesn't allow you to do this, there is nothing we can do on our end. (Considering that you're using an illegal cracked version of the game, you should probably just buy the game and use another launcher)

@EvaLinn
Copy link

EvaLinn commented Mar 16, 2024

I can't delete the file because my launcher loads it again :( Modpack in TLauncher. You should ask someone else to help XD

You should update the SerializationIsBad mod to 1.5.1. If your launcher doesn't allow you to do this, there is nothing we can do on our end. (Considering that you're using an illegal cracked version of the game, you should probably just buy the game and use another launcher)

I have license, but I don't like official Minecraft Launcher. It's much easier for me to make modpacks in TLauncher. And yeah, it doesn't allow me to update the mod

@HeatherComputer
Copy link
Collaborator

I have license, but I don't like official Minecraft Launcher. It's much easier for me to make modpacks in TLauncher. And yeah, it doesn't allow me to update the mod

Then use something like Prism Launcher. TLauncher is illegal and is known for stealing legitimate accounts.
There's also the official Modrinth and Curseforge launchers.

@xJon
Copy link
Author

xJon commented Mar 16, 2024

@dogboy21 Replacing 1.5 with 1.5.1 does not appear to work - https://mclo.gs/zthspOM

@dogboy21
Copy link
Owner

If you already have a serializationisbad.json in your config folder, try deleting that before starting the game.

@xJon
Copy link
Author

xJon commented Mar 16, 2024

@dogboy21 Resetting it appears to work 🎉

@dogboy21
Copy link
Owner

Alright, then I know what the issue is, thank you for testing!
The old config URL was still present in that config, so there was pretty much no difference with the 1.5.1 version.
I will release a new version 1.5.2 later today which replaces that old URL as well, so it also should work for older instances with the old config.

@dogboy21
Copy link
Owner

1.5.2, which replaces the old URL with the new one, is now released as well :)
Will also upload it to CF/Modrinth in a few minutes

@dogboy21 dogboy21 removed the awaiting for response awaiting a response from user label Mar 16, 2024
@xJon
Copy link
Author

xJon commented Mar 16, 2024

@dogboy21 I can confirm it works :)

@dogboy21
Copy link
Owner

Alright, thank you for testing!

@dogboy21 dogboy21 unpinned this issue Mar 16, 2024
@dogboy21 dogboy21 pinned this issue Mar 16, 2024
@felipeleite5w
Copy link

Hey, sorry for the dumb question, but do I need to update the mod or just delete the mod config ? Thanks!

@dogboy21
Copy link
Owner

If you're currently using version 1.4 or above, setting remoteConfigUrl in the config to https://serializationisbad.dogboy.io/serializationisbad.json should be enough.
Otherwise update to 1.5.2 which already has that fix builtin.
Deleting the config file isn't neccessary with 1.5.2.

@felipeleite5w
Copy link

Perfect! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants