Skip to content

Commit

Permalink
Decrease the frequency of reconcilation requests for healthy DNS-SD i…
Browse files Browse the repository at this point in the history
…nstances.
  • Loading branch information
jmalloc committed Jan 12, 2024
1 parent e9633ef commit 0a9a3a9
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 5 deletions.
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@ The format is based on [Keep a Changelog], and this project adheres to

<!-- REMEMBER TO BUMP THE VERSIONS IN THE CHART FILE -->

## [0.4.12] - 2024-01-12

### Changed

- Decrease the frequency of reconcilation requests for healthy DNS-SD instances
(10 times TTL). This is a hack to reduce the likelyhood of false negatives
until a fix can be applied to the upstream dependency `dogmatiq/dissolve`.

## [0.4.11] - 2024-01-12

### Added
Expand Down Expand Up @@ -172,6 +180,9 @@ The format is based on [Keep a Changelog], and this project adheres to
[0.4.7]: https://github.com/dogmatiq/proclaim/releases/tag/v0.4.7
[0.4.8]: https://github.com/dogmatiq/proclaim/releases/tag/v0.4.8
[0.4.9]: https://github.com/dogmatiq/proclaim/releases/tag/v0.4.9
[0.4.10]: https://github.com/dogmatiq/proclaim/releases/tag/v0.4.10
[0.4.11]: https://github.com/dogmatiq/proclaim/releases/tag/v0.4.11
[0.4.12]: https://github.com/dogmatiq/proclaim/releases/tag/v0.4.12

<!-- version template
## [0.0.1] - YYYY-MM-DD
Expand Down
4 changes: 2 additions & 2 deletions charts/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ apiVersion: v2
name: proclaim
description: A Kubernetes controller and CRD that publishes DNS-SD records.
type: application
version: v0.4.11
appVersion: v0.4.11
version: v0.4.12
appVersion: v0.4.12
icon: https://dogmatiq.io/res/img/icon-144x144.png
6 changes: 3 additions & 3 deletions reconciler/advertise.go
Original file line number Diff line number Diff line change
Expand Up @@ -178,15 +178,15 @@ func (r *Reconciler) requeueResult(
reason = "drift detection"
delay = res.Spec.Instance.TTL.Duration
} else if discoveredTTL == 0 {
// We have no TTL information from actual DNS records, so we use
// the TTL from the specification.
// We have no TTL information from actual DNS records, so we compute
// something based on the TTL.
//
// HACK: This doesn't really have anything to do with the TTL, we're
// just using it as a (hopefully) reasonable indicator of how long we
// should wait before re-trying. It would be better if the provider
// could give us retry intervals based on the zone's SOA record (e.g.
// negative cache times) and/or API rate limiting.
delay = res.Spec.Instance.TTL.Duration
delay = 10 * res.Spec.Instance.TTL.Duration
reason = "not discoverable"
} else {
// Otherwise, we wait long enough for the mismatching discovered DNS
Expand Down

0 comments on commit 0a9a3a9

Please sign in to comment.