Skip to content

Commit

Permalink
Use case-insensitive comparison when detecting hostname drift
Browse files Browse the repository at this point in the history
  • Loading branch information
jmalloc committed Nov 6, 2023
1 parent 298eefc commit 99967b5
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@ The format is based on [Keep a Changelog], and this project adheres to

<!-- REMEMBER TO BUMP THE VERSIONS IN THE CHART FILE -->

## [0.4.7] - 2023-11-07

### Fixed

- Use case-insensitive comparison when detecting hostname drift

## [0.4.6] - 2023-11-07

### Fixed
Expand Down
4 changes: 2 additions & 2 deletions charts/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ apiVersion: v2
name: proclaim
description: A Kubernetes controller and CRD that publishes DNS-SD records.
type: application
version: v0.4.6
appVersion: v0.4.6
version: v0.4.7
appVersion: v0.4.7
icon: https://dogmatiq.io/res/img/icon-144x144.png
2 changes: 1 addition & 1 deletion reconciler/discover.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ func (r *Reconciler) computeDiscoverable(
// compare returns a (very) brief human-readable description of the differences
// between the observed and desired service instance records.
func compare(observed, desired dnssd.ServiceInstance) (string, bool) {
if observed.TargetHost != desired.TargetHost {
if !strings.EqualFold(observed.TargetHost, desired.TargetHost) {
return fmt.Sprintf("host %q != %q", observed.TargetHost, desired.TargetHost), false
}

Expand Down

0 comments on commit 99967b5

Please sign in to comment.