Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onchain Chess tutorial updated to 0.3.0 #82

Merged
merged 19 commits into from
Oct 18, 2023
Merged

Onchain Chess tutorial updated to 0.3.0 #82

merged 19 commits into from
Oct 18, 2023

Conversation

Akinbola247
Copy link
Contributor

In reference to this issue #71 , the onchain chess tutorial has been updated to 0.3.0. Check the full tutorial code here https://github.com/Akinbola247/chess-dojo/tree/tutorialv3 . Worked together with @gianalarcon to pull this off. kindly review this, i'll await your feedback

@Akinbola247 Akinbola247 mentioned this pull request Oct 17, 2023
Closed
ponderingdemocritus
ponderingdemocritus approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@ponderingdemocritus ponderingdemocritus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

rkdud007
rkdud007 reviewed Oct 18, 2023
View reviewed changes
Copy link
Contributor

@rkdud007 rkdud007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just merged pr from @Akinbola247 @gianalarcon 's v0.3.0. Cus we restoring all the branch, might good to change this link

src/tutorial/onchain-chess/README.md Outdated Show resolved Hide resolved
src/tutorial/onchain-chess/1-action.md Outdated Show resolved Hide resolved
@rkdud007
Copy link
Contributor

actually how about we just include this chess project code inside the dojo book? It would be much better to upgrade the book content and tutorial with dojo version upgrade

@gianalarcon
Copy link
Collaborator

gianalarcon commented Oct 18, 2023 •
edited
Loading

actually how about we just include this chess project code inside the dojo book? It would be much better to upgrade the book content and tutorial with dojo version upgrade

Dojo team have a dojo-examples repo, we could include the chess-game there. What do you suggest @ponderingdemocritus ?

@gianalarcon gianalarcon merged commit 6404b2e into dojoengine:main Oct 18, 2023
1 check passed
@Akinbola247
Copy link
Contributor Author

actually how about we just include this chess project code inside the dojo book? It would be much better to upgrade the book content and tutorial with dojo version upgrade

I agree with @gianalarcon , it will be nice to have the chess game included in dojo-examples. What do you think @rkdud007 @ponderingdemocritus

@rkdud007
Copy link
Contributor

dojoengine/dojo#903 @Akinbola247 @gianalarcon check this

@ponderingdemocritus
Copy link
Contributor

great idea - let's include it there!

@rkdud007 rkdud007 mentioned this pull request Oct 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkdud007 rkdud007 rkdud007 left review comments

@ponderingdemocritus ponderingdemocritus ponderingdemocritus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Akinbola247 @rkdud007 @gianalarcon @ponderingdemocritus