-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add maze generation feature #90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!
Some comments, and more generally:
- Would be great to have an explanation of the differences between a room, a cave and a maze. For a better understanding of the terms used.
- As
generate_trait
is used, having a doc on the function could help one diving and re-using this code base to apply it in different games.
Amazing work @bal7hazar. 🚀
I have performed a big refactoring which should allow developers to either use the high level usage I have added a bunch of doc in the code, but I could have miss some and maybe not detailed enough, just tell me if something is unclear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bal7hazar thanks for this great effort on documentation and bringing this to origami!
I've made some comments say are not forced to be addressed here since the usage of the functions is controlled. May be addressed later to not relay the work on the other PR that uses this one. Feel free to merge if so.
Also, I was wondering at first why not using a more object oriented approach but I guess it's way more optimized gas wise doing the way you did it.
Amazing job. 💪
Closes #
Introduced changes
Checklist