Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] .hyper.js fontFamily settings not working. #37

Merged
merged 1 commit into from
Mar 28, 2021
Merged

[Fix] .hyper.js fontFamily settings not working. #37

merged 1 commit into from
Mar 28, 2021

Conversation

VergeDX
Copy link
Contributor

@VergeDX VergeDX commented Mar 28, 2021

I noticed that "fontFamily" section of config file .hyper.js not working, so I search for these issues.
Here is what I found: vercel/hyper#3343 (comment). Then I realize these issues may be caused by the theme.
I check out the code of https://github.com/defringe/verminal and seems we shouldn't define the section "fontFamily" in the file "src/syntax.ts".
This is what theme verminal do: https://github.com/defringe/verminal/blob/master/index.js#L62

@VergeDX
Copy link
Contributor Author

VergeDX commented Mar 28, 2021

@Unthrottled
Also, I suggest apply css .tabs_title { color: #000000 } (Title color: black) in Light theme,
apply .tabs_title { color: #FFFFFF } (Title color white) in Dark theme.

Copy link
Member

@Unthrottled Unthrottled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! I hadn't realized I was over-writing those settings when the Toggle Fonts action wasn't selected.

Can confirm that this works as expected when Toggle Fonts is not active.

Thank you!

@Unthrottled
Copy link
Member

Also, I suggest apply css .tabs_title { color: #000000 } (Title color: black) in Light theme,
apply .tabs_title { color: #FFFFFF } (Title color white) in Dark theme.

Any particular reason (a particular theme)? I went through all of the themes and they all appear to be using the foregroundColor as defined in the master definition.

@Unthrottled Unthrottled merged commit 97ea9ca into doki-theme:master Mar 28, 2021
@Unthrottled
Copy link
Member

Changes have been published, thanks again!

@VergeDX
Copy link
Contributor Author

VergeDX commented Mar 29, 2021

@Unthrottled
Well because my Hyper terminal title font color is always white, like the screenshot below.
So I have no choice to add CSS .tabs_title { color: #000000 }...
image
This is strange because I noticed your screenshot in #30, your hyper terminal title color has no such issue...
So I think there are issues with plugins or macOS, can you share your plugins list...?
Thanks.

@Unthrottled
Copy link
Member

Ah, I saw the issue as well. I was on v8.0.0 after taking the v8.1.1 update and restarting hyper, it went to this
Screen Shot 2021-03-29 at 5 21 02 PM

I am also using the canary version

Screen Shot 2021-03-29 at 5 21 27 PM

Let me know if upgrading and restarting works for you. @VergeDX

@VergeDX
Copy link
Contributor Author

VergeDX commented Mar 29, 2021

Oh yes, I noticed it becomes normal XD.
Thanks for patients <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants