Force NetPlay Clients to Host Hardcore Status

[LillyJadeKatrin]

If the host is in hardcore mode, all joining players will be set to hardcore mode; if not, all joining players will be set to softcore.

[JosJuice]

Please make sure that this builds correctly when USE_RETRO_ACHIEVEMENTS is disabled. Currently you have a problem where you unconditionally use Config::RA_HARDCORE_ENABLED, whose declaration is behind an ifdef.

(Note that the netplay packet layout must be the same regardless of whether USE_RETRO_ACHIEVEMENTS is enabled.)

[JMC47]

What happens if the joining players aren't logged into RetroAchievements?

[LillyJadeKatrin]

Host logged in with hardcore on, join not logged in - all players see hardcore mode on
Host not logged in, join logged in with hardcore on - all players see hardcore mode off
Designed that way and verified via testing.

[JosJuice]

The commit message should mention why this change is needed (which as I understand it is because otherwise different clients would get different code filtering).

[JosJuice]

Now that you're using a config changed callback to call SetHardcoreMode, you should get rid of all calls to SetHardcoreMode from outside AchievementManager.cpp.

Also, please keep in mind that config changed callbacks can run from any thread. SetHardcoreMode uses m_client with no locking. Have you thought through the thread safety implications of this? (Personally I'm not sure what's safe and not, because I haven't been able to find any documentation on the rcheevos library's thread safety requirements.)

[LillyJadeKatrin]

I removed it from the only other place I could find it and verified it still worked. As for thread safety, rc_client_set_hardcore_enabled has an internal mutex.

[JosJuice]

Hold on, I forgot one thing. You haven't updated the commit message to explain why the change is desired.