Liuliu/electron app #1
Conversation
package.json
Outdated
| "clean": "tsc -b --clean && yarn yalc:clean", | ||
| "compile": "tsc -b" |
There was a problem hiding this comment.
Should these use the clean and compile scripts from the workspaces instead? Like we do in ld/web
schema.gql
Outdated
| @@ -0,0 +1,376 @@ | |||
| # ------------------------------------------------------ | |||
There was a problem hiding this comment.
Doesn't seem like this file belongs here? Isn't this already in graphql-server?
web/contexts/serverConfig.tsx
Outdated
| function useServerConfigIPC(): { | ||
| data: ServerConfigContextValue | undefined; | ||
| error: any; | ||
| } { |
There was a problem hiding this comment.
Can you move this return type to a declared type? Can also use the type for InnerProps since they share data and error
| return process.env.NEXT_PUBLIC_FOR_ELECTRON === "true" ? ( | ||
| <IPCConfigProvider>{children}</IPCConfigProvider> | ||
| ) : ( | ||
| <APIConfigProvider>{children}</APIConfigProvider> | ||
| ); |
There was a problem hiding this comment.
Could use a comment here for what this does/why
web/hooks/useUserHeaders.ts
Outdated
| const fetchHeaders = async () => { | ||
| const response = await fetch("/api/headers"); // This endpoint should return headers | ||
| const headersData = await response.json(); | ||
| const user = headersData["x-forwarded-user"]; | ||
| const email = headersData["x-forwarded-email"]; | ||
| if (user || email) { | ||
| setHeaders({ user, email }); | ||
| } | ||
| }; | ||
|
|
||
| await fetchHeaders(); |
There was a problem hiding this comment.
Was there a reason you changed this?
web/next.config.js
Outdated
| loader: 'webpack-preprocessor-loader', | ||
| options: { | ||
| params: { | ||
| isWeb: process.env.NEXT_PUBLIC_FOR_ELECTRON!=="true", |
There was a problem hiding this comment.
isWeb isn't the clearest name. Maybe isElectron and do #!if !isElectron in the pages?
| isWeb: process.env.NEXT_PUBLIC_FOR_ELECTRON!=="true", | |
| isElectron: process.env.NEXT_PUBLIC_FOR_ELECTRON === "true", |
| test: /\.tsx$/, | ||
| use: [ | ||
| { | ||
| loader: 'webpack-preprocessor-loader', |
There was a problem hiding this comment.
This could also use a comment for its purpose
| @@ -5,14 +5,14 @@ import { GetServerSideProps, NextPage } from "next"; | |||
|
|
|||
| type Params = RefParams & { | |||
| diffRange: string; | |||
| tableName?: string; | |||
There was a problem hiding this comment.
I wouldn't expect there to be any params/props changes in this PR? Where are all of these coming from?
web/postcss.config.js
Outdated
| module.exports = { | ||
| plugins: { | ||
| "tailwindcss/nesting": {}, | ||
| tailwindcss: {}, | ||
| tailwindcss: { ...tailwindConfig }, |
web/tailwind.config.js
Outdated
| @@ -0,0 +1,24 @@ | |||
| const { mergeConfig } = require("@dolthub/react-components"); | |||
| }} | ||
| compare | ||
| /> | ||
| <DatabasePage.ForCommits params={params} compare /> |
There was a problem hiding this comment.
tableName needs to be passed explicitly here
| @@ -6,8 +6,8 @@ import { GetServerSideProps, NextPage } from "next"; | |||
| type Props = { | |||
| params: TableParams & { | |||
| active?: string; | |||
| edit?: boolean; | |||
There was a problem hiding this comment.
edit needs to be explicitly passed to DatabasePage.ForTable now that it isn't a prop
To run in dev mode: run
yarn devin the root directory.Changes:
add
package.jsonin root directory, putwebandgraphql-serverinworkspaces.In
main:background.tsstarts the main process, creates the app window and loads the built files.createGraphqlSeverProcessexecutes a child process to spawn the GraphQL server.preload.tsestablishes the IPC handler for communication between the renderer and the main process.web:pages, commentedgetServerSidePropsbecause server side rendering is not allowed.serverConfig.tsx, useipcto get the api/config, sinceapiroute is not allowed in nextron build.graphql-server:After the app is built, writing schema.gql file in the app is not allowed since the app is readonly. We will write the file to the user's application data folder specified by
process.env.SCHEMA_PATH. This path is set inbackground.tsas follows:const schemaPath = path.join(userDataPath, "schema.gql");Existing issues:
Distributing the built macOS application have an issue due to the "com.apple.Quarantine" attribute applied when the app is not downloaded from an Apple-sanctioned source. A temporary workaround involves disabling Gatekeeper for the app with the command:
xattr -c <path/to/application.app>A more permanent solution requires getting an Apple Developer account, a Team ID for our developer team, and add this ID into the build configuration: