[rowexec] full outer join rightIter exhaust #2814
Conversation
|
This is awesome 🎉 |
| @@ -463,7 +468,7 @@ func (i *fullJoinIter) Next(ctx *sql.Context) (sql.Row, error) { | |||
| } | |||
| if _, ok := i.seenLeft[key]; !ok { | |||
| // (left, null) only if we haven't matched left | |||
There was a problem hiding this comment.
Is this comment still correct? It says null but you've replaced the nil in the LoC below.
| @@ -520,7 +525,7 @@ func (i *fullJoinIter) Next(ctx *sql.Context) (sql.Row, error) { | |||
| continue | |||
| } | |||
| // (null, right) only if we haven't matched right | |||
There was a problem hiding this comment.
Is this comment still correct? It says null but you've replaced the nil in the LoC below.
|
@max-hoffman I asked a question in a previous comment after you merged, but figured I should tag you in case you missed my comments. Also:
Should this be updated now? |
Yes thanks for the reminder, I fixed the docs here. |
Full join should exhaust right side, not return as soon as we EOF the left iterator.
fixes: dolthub/dolt#8735