Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow inline column check constraint definitions to appear in any order #295

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

fulghum
Copy link

@fulghum fulghum commented Dec 19, 2023

Previously, an inline column check constraint could only appear as the very last option for a column definition. This change allows it to appear in other positions in the column definition. For example, this query now works:

create table t123 (c1 varchar(5) check (c1 in ('v1', 'v2')) NOT NULL);

Resolves: dolthub/dolt#7195

…order in a column definition, instead of only at the very end
@fulghum fulghum marked this pull request as ready for review December 19, 2023 23:56
@fulghum fulghum requested a review from zachmu as a code owner December 19, 2023 23:56
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fulghum fulghum merged commit 3729729 into main Dec 20, 2023
4 checks passed
@fulghum fulghum deleted the fulghum/inline-check-position branch December 20, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error parsing CREATE TABLE with both CHECK and NOT NULL
2 participants