Fix typescript 5.5 parse for configDir #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are broken on windows due to wrong implementation of #178, I'll fix there and rebase this on that |
lPernod-sorare
force-pushed
the
fix-ts-5.5-parse
branch
from
0d1ade4
to
c44024b
Compare
|
thank you so much. You'll also have to run If you are ok with it i'll push an extra testcase to ensure it doesn't regress and improve the ts 5.5 logic a bit. |
|
done, i did shorten the baseUrl implementation a bit and made it resilient for future tokens apart from configDir (although these need to be added to replaceTokens then). |
Merged
This was referenced Jun 27, 2024
|
Thanks a lot for catching this @lPernod-sorare ! it will be released with the next vite patch too. |
|
released in vite 5.3.2 https://github.com/vitejs/vite/blob/v5.3.2/packages/vite/CHANGELOG.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #178 and fixes differences between parse and parseNative for configDir for typescript 5.5