test_round_3 added to loading #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #125 |
lima-tango
reviewed
Apr 24, 2021
| df_r3 = pd.read_csv(file_cached) | ||
|
|
||
| except: |
There was a problem hiding this comment.
It is good practice to hande errrors explicitly:
except FileError:| df_r3.query(f'id_article=={i} and {label}==1').sample(1, | ||
| random_state=42))) | ||
| id_list.extend(list(df_ann.id_post)) |
There was a problem hiding this comment.
Small comment on efficiency: extending a list is not efficient. You could also use df_ann after both for-loops:
id_list = list(df_ann.id_post.unique())
return id_list # or directly return the above| def get_augmented_val_id(): |
There was a problem hiding this comment.
You are douplicating code from get_augmented_val_X_y. Best practise would be to use this function (get_augmented_val_id) in the X_y-function.
|
In branch issue-131-gbert-advanced-training I had built an alternative solution to #125 (i.e. test the gbert model on the annotation round 3 data). It's found in the 2 commits 81c452d and 4a2a39a combined. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.