Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permissions in merge mode #1038

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add permissions in merge mode #1038

wants to merge 1 commit into from

Conversation

gbrlsnts
Copy link

@gbrlsnts gbrlsnts commented Oct 9, 2024

Set permissions in merge mode to allow to be used with other plugins

Set permissions in merge mode to allow to be used with other plugins
@peitschie
Copy link
Collaborator

Hi @gbrlsnts

Thanks for the patch, but this doesn't seem like it does what we're hoping. Based on https://cordova.apache.org/docs/en/12.x/plugin_ref/spec.html#edit-config, I think each individual permission needs to be targeted specifically via edit-config.

For example:

<edit-config target="AndroidManifest.xml" parent="/manifest/uses-permission[@android:name='android.permission.ACCESS_COARSE_LOCATION']" mode="merge">
    <uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" android:maxSdkVersion="28"/>
</edit-config>
<edit-config target="AndroidManifest.xml" parent="/manifest/uses-permission[@android:name='android.permission.ACCESS_FINE_LOCATION']" mode="merge">
    <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" android:maxSdkVersion="28"/>
</edit-config>
...

Are you able to check this out locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants