bgpd: Avoid unnecessary creation and free of json object

In peer_adj_routes_brief(), the 'json' variable is only used for early
exit i.e. during early warning conditions. No point in creating and
freeing the json object everytime during non early exit cases (Majority
of the times)

Ticket :#4081784

Signed-off-by: Rajasekar Raja <[email protected]>

bgpd/bgp_route.c

@@ -14485,15 +14485,16 @@ static int peer_adj_routes_brief(struct vty *vty, struct peer *peer, afi_t afi,
 	json_object *json_prefix = NULL; /* JSON per prefix */
 	struct bgp_dest *dest;
 
-	json = json_object_new_object();
 	if (!peer || !peer->afc[afi][safi]) {
+		json = json_object_new_object();
 		json_object_string_add(json, "warning", "No such neighbor or address family");
 		vty_out(vty, "%s\n", json_object_to_json_string(json));
 		json_object_free(json);
 		return CMD_WARNING;
 	}
 	if ((type == bgp_show_adj_route_received || type == bgp_show_adj_route_filtered) &&
 	    !CHECK_FLAG(peer->af_flags[afi][safi], PEER_FLAG_SOFT_RECONFIG)) {
+		json = json_object_new_object();
 		json_object_string_add(json, "warning", "Inbound soft reconfiguration not enabled");
 		vty_out(vty, "%s\n", json_object_to_json_string(json));
 		json_object_free(json);