Skip to content

Commit

Permalink
zebra: remove log for RTM_DELNEIGH of unknown mac
Browse files Browse the repository at this point in the history
cache, don't log the failed removal.
Zebra was generating unhelpful error logs (nothing apparent for
the operator to learn/do based on the info) when an RTM_DELNEIGH
arrived for a MAC that is not in our local MAC cache:
```
var/log/frr/frr.log:2022-07-30T15:05:25.985778-07:00 leaf01 zebra[8956]: Failed to find local MAC cache for bridge bridge vid 219 mac 00:55:01:00:01:b1 at DEL
var/log/frr/frr.log:2022-07-30T15:05:25.985854-07:00 leaf01 zebra[8956]: Failed to find local MAC cache for bridge bridge vid 217 mac 00:55:01:00:01:35 at DEL
var/log/frr/frr.log:2022-07-30T15:05:25.985943-07:00 leaf01 zebra[8956]: Failed to find local MAC cache for bridge bridge vid 203 mac 00:33:01:00:00:ad at DEL
```

This can occur during normal timing events (like reading the kernel fdb
on startup), and during irregular events there isn't anything for an
operator to do.  So let's skip that error log.

Ticket: #3158836

Signed-off-by: Trey Aspelund <[email protected]>
  • Loading branch information
Trey Aspelund authored and donaldsharp committed Dec 7, 2024
1 parent 2ca1247 commit bfd173e
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions zebra/rt_netlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -3894,10 +3894,6 @@ static int netlink_macfdb_change(struct nlmsghdr *h, int len, ns_id_t ns_id)
bmac = zebra_l2_brvlan_mac_find(br_if, vid, &mac);
if (bmac)
zebra_l2_brvlan_mac_del(br_if, bmac);
else
zlog_err(
"Failed to find local MAC cache for bridge %s vid %u mac %pEA at DEL",
br_if->name, vid, &mac);

return zebra_vxlan_local_mac_del(ifp, br_if, &mac, vid);
}
Expand Down

0 comments on commit bfd173e

Please sign in to comment.