lib: Warn operator when fd limit is set too large

It's unlikely that an operator will ever set a fd limit of over 100k. Let's warn the operator that things are in a bit of a wonky state. Fixes: FRRouting#15280 Signed-off-by: Donald Sharp <[email protected]>
donaldsharp · Feb 2, 2024 · d023a0c · d023a0c
1 parent a2caf2b
commit d023a0c
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/lib/event.c b/lib/event.c
@@ -543,6 +543,7 @@ static void initializer(void)
 	pthread_key_create(&thread_current, NULL);
 }
 
+#define STUPIDLY_LARGE_FD_SIZE 100000
 struct event_loop *event_master_create(const char *name)
 {
 	struct event_loop *rv;
@@ -569,6 +570,10 @@ struct event_loop *event_master_create(const char *name)
 		rv->fd_limit = (int)limit.rlim_cur;
 	}
 
+	if (rv->fd_limit > STUPIDLY_LARGE_FD_SIZE)
+		zlog_warn("FD Limit set: %u is stupidly large.  Is this what you intended?  Consider using --limit-fds",
+			  rv->fd_limit);
+
 	rv->read = XCALLOC(MTYPE_EVENT_POLL,
 			   sizeof(struct event *) * rv->fd_limit);