Skip to content

Commit

Permalink
bgpd: Just pass down the Bandwidth unmodified so that Zebra can use it
Browse files Browse the repository at this point in the history
Instead of scaling the bandwith to something between 1 and 100, just
send down the bandwidth Available for the link.

Signed-off-by: Donald Sharp <[email protected]>
  • Loading branch information
donaldsharp committed Oct 12, 2023
1 parent e915655 commit dc8a5c5
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions bgpd/bgp_zebra.c
Original file line number Diff line number Diff line change
Expand Up @@ -1209,24 +1209,18 @@ static bool update_ipv6nh_for_route_install(int nh_othervrf, struct bgp *nh_bgp,
static bool bgp_zebra_use_nhop_weighted(struct bgp *bgp, struct attr *attr,
uint64_t tot_bw, uint32_t *nh_weight)
{
uint32_t bw;
uint64_t tmp;

bw = attr->link_bw;
/* zero link-bandwidth and link-bandwidth not present are treated
* as the same situation.
*/
if (!bw) {
if (!attr->link_bw) {
/* the only situations should be if we're either told
* to skip or use default weight.
*/
if (bgp->lb_handling == BGP_LINK_BW_SKIP_MISSING)
return false;
*nh_weight = BGP_ZEBRA_DEFAULT_NHOP_WEIGHT;
} else {
tmp = (uint64_t)bw * 100;
*nh_weight = ((uint32_t)(tmp / tot_bw));
}
} else
*nh_weight = attr->link_bw;

return true;
}
Expand Down

0 comments on commit dc8a5c5

Please sign in to comment.