improve prompt, update comment

doodledood · Nov 13, 2023 · f7f6162 · f7f6162
1 parent bedb4de
commit f7f6162
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 5 deletions.
diff --git a/chatflock/composition_generators/langchain.py b/chatflock/composition_generators/langchain.py
@@ -261,7 +261,13 @@ def create_compose_chat_participants_system_prompt(self, chat: "Chat") -> str:
                                     list=[
                                         "Only individual participants can be given tools.",
                                         "You must only choose a tool from the AVAILABLE PARTICIPANT TOOLS list.",
-                                        "A tools should be given to a participant only if it can help them achieve the goal.",
+                                        "A tools should be given to a participant only if it can help them fulfill their personal mission better.",
+                                    ],
+                                ),
+                                Section(
+                                    name="Correct Hierarchical Composition",
+                                    list=[
+                                        "If you add a team, make sure to add the team as a participant, and not its individual members."
                                     ],
                                 ),
                             ],
@@ -361,7 +367,7 @@ def create_compose_chat_participants_first_human_prompt(
         messages = chat.get_messages()
         messages_list = [f"- {message.sender_name}: {message.content}" for message in messages]
 
-        available_tools_list = list(set(f'{x.name}: "{x.description}"' for x in participant_available_tools or []))
+        available_tools_list = list({f'{x.name}: "{x.description}"' for x in participant_available_tools or []})
 
         active_participants = chat.get_active_participants()
 

diff --git a/chatflock/participants/langchain.py b/chatflock/participants/langchain.py
@@ -111,6 +111,15 @@ def create_system_message(self, chat: "Chat", relevant_docs: Sequence[Document])
                                     ]
                                 ),
                             ),
+                            Section(
+                                name="Guidelines",
+                                list=[
+                                    "Your personal mission is the most important thing to you. You should always "
+                                    "prioritize it.",
+                                    "If a chat goal is provided, you should still follow your personal mission but "
+                                    "in a way that helps the group achieve the chat goal.",
+                                ],
+                            ),
                             Section(
                                 name="Rules",
                                 list=[

diff --git a/examples/automatic_hierarchical_chat_composition.py b/examples/automatic_hierarchical_chat_composition.py
@@ -3,7 +3,6 @@
 import typer
 from dotenv import load_dotenv
 from halo import Halo
-from langchain.llms.openai import OpenAI
 from langchain.memory import ConversationSummaryBufferMemory
 
 from chatflock.backing_stores import InMemoryChatDataBackingStore
@@ -52,8 +51,9 @@ def create_chat(**kwargs: Any) -> Chat:
         initial_participants=[user],
     )
 
-    # Not necessary in practice since initiation is done automatically when calling `initiate_chat_with_result`.
-    # However, this is needed to eagerly generate the composition. Default is lazy.
+    # It's not necessary in practice to manually call `initialize_chat` since initiation is done automatically
+    # when calling `initiate_chat_with_result`. However, this is needed to eagerly generate the composition.
+    # Default is lazy and will happen when the chat is initiated.
     chat_conductor.initialize_chat(
         chat=chat,
         # Only relevant when passing in a composition generator