Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker to this project #20

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Docker to this project #20

wants to merge 2 commits into from

Conversation

kawaegle
Copy link

@kawaegle kawaegle commented Jun 1, 2023

this is a way to implement docker for your project.

@doprz
Copy link
Owner

doprz commented Aug 9, 2023

Thank you for your first PR and my apologies for taking a while to respond.

Would it be possible to add layer caching to the PR for faster building?

Also what are your thoughts on using a different base such as:

  • scratch
  • alpine
  • bullseye-slim

My goal with these questions is to explore how we can create faster and more efficient Docker builds.

@kawaegle
Copy link
Author

kawaegle commented Aug 9, 2023

I'm currently learning docker and so i'll see what I can to lightweigth the images

@kawaegle
Copy link
Author

kawaegle commented Aug 9, 2023

Did you try to build the image ?

For me i get with thé actual version

user@machine: docker images 
dipc-test.   92.6Mb

And with rust:slim

user@machine: docker images 
dipc-slim.      86.1Mb

The major problem I get is when i use alpine or anything like this I get missing librairies for thé launchable docker

And if I compile with rust:alpine there is linking error.

Must i can save is using slim images.

Hope it help a little

@doprz
Copy link
Owner

doprz commented Aug 10, 2023

Interesting. I will work on this and get back to you as soon as I can.

@kawaegle
Copy link
Author

i'll finally found out to compile and have a workaround with alpine
now:
localhost/dipc latest bc8c90d9b0bc 5 minutes ago 16.4 MB
much better but there is maybe a better way to split the built to optimize cargo build (maybe in release mode) I don't use rust that much

@doprz doprz changed the title try to docker to this project Add Docker to this project Aug 21, 2023
@doprz
Copy link
Owner

doprz commented Aug 21, 2023

Great work! We can focus on performance improvements later on, for now the PR just needs minor adjustments before being merged.

@kawaegle
Copy link
Author

I still learning and I appreciate that i was not judge by my first PR

if you need anything else let me know

@doprz
Copy link
Owner

doprz commented Aug 22, 2023

Don't worry, we're here to learn and your PR is a great contribution to dipc.
I will finish reviewing the PR this week. Great job and once again thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants