-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker to this project #20
base: main
Are you sure you want to change the base?
Conversation
Thank you for your first PR and my apologies for taking a while to respond. Would it be possible to add layer caching to the PR for faster building? Also what are your thoughts on using a different base such as:
My goal with these questions is to explore how we can create faster and more efficient Docker builds. |
I'm currently learning docker and so i'll see what I can to lightweigth the images |
Did you try to build the image ? For me i get with thé actual version user@machine: docker images
dipc-test. 92.6Mb And with rust:slim user@machine: docker images
dipc-slim. 86.1Mb The major problem I get is when i use alpine or anything like this I get missing librairies for thé launchable docker And if I compile with rust:alpine there is linking error. Must i can save is using slim images. Hope it help a little |
Interesting. I will work on this and get back to you as soon as I can. |
i'll finally found out to compile and have a workaround with alpine |
Great work! We can focus on performance improvements later on, for now the PR just needs minor adjustments before being merged. |
I still learning and I appreciate that i was not judge by my first PR if you need anything else let me know |
Don't worry, we're here to learn and your PR is a great contribution to |
this is a way to implement docker for your project.