Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(action): SDK Publish Workflow #188

Merged
merged 2 commits into from
Feb 3, 2025
Merged

test(action): SDK Publish Workflow #188

merged 2 commits into from
Feb 3, 2025

Conversation

zJaaal
Copy link

@zJaaal zJaaal commented Feb 3, 2025

This pull request includes several changes to the deployment process for the JavaScript SDK in the .github/actions/core-cicd/deployment/deploy-javascript-sdk/action.yml file. The primary focus is on updating the versioning and tagging system from "alpha" to "beta".

Changes to versioning and tagging:

  • Updated the example projects to point to the 'next' tag instead of 'latest' to prevent version inconsistency.
  • Changed the default npm-package-tag from 'alpha' to 'beta'.
  • Modified the script to fetch the current version using the 'beta' tag instead of 'alpha', and set the initial version to "0.0.1-beta.0" if no current version is found.
  • Adjusted the version calculation logic to increment the beta version number instead of the alpha number.
  • Changed the npm dist-tag addition command to use the 'next' tag instead of 'latest'.

@zJaaal zJaaal requested a review from a team as a code owner February 3, 2025 16:43
Copy link

@sfreudenthaler sfreudenthaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

safe to proceed for the test repo. Would want to see it running clean before approving in dotCMS/core

Copy link

@dcolina dcolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@zJaaal zJaaal enabled auto-merge February 3, 2025 17:10
@zJaaal zJaaal added this pull request to the merge queue Feb 3, 2025
Merged via the queue into main with commit 0e288b1 Feb 3, 2025
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants