-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ultrawide testing #160
base: master
Are you sure you want to change the base?
ultrawide testing #160
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 8 out of 10 changed files in this pull request and generated no suggestions.
Files not reviewed (2)
- src/components/Overlay/NotablePlayers.tsx: Evaluated as low risk
- src/lib/devConsts.ts: Evaluated as low risk
Comments skipped due to low confidence (1)
src/components/Overlay/index.tsx:283
- The alt attribute should be updated to match the new src value for accessibility reasons. Suggest changing it to '21-9 playing dev screenshot'.
alt={`${block.type} dev screenshot`}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 8 out of 10 changed files in this pull request and generated 2 comments.
Files not reviewed (2)
- src/components/Overlay/NotablePlayers.tsx: Evaluated as low risk
- src/components/Overlay/PollOverlay.tsx: Evaluated as low risk
return () => window.removeEventListener('resize', handleResize) | ||
}, []) // Empty array ensures that effect is only run on mount | ||
}, [windowSize]) // Add windowSize as a dependency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Including windowSize in the useEffect dependency array can cause an infinite loop. The dependency array should be empty to ensure the effect runs only once on mount.
}, [windowSize]) // Add windowSize as a dependency | |
}, []) // Empty array ensures that effect is only run on mount |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
src={`/images/dev/${ | ||
block.type === 'spectator' ? 'playing' : block.type | ||
}.png`} | ||
src={`/images/dev/21-9-playing.png`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoding the image path to '21-9-playing.png' might be incorrect. The original code dynamically set the image source based on the block.type. Consider reverting to the dynamic path construction.
src={`/images/dev/21-9-playing.png`} | |
src={`/images/dev/${block.type === 'spectator' ? 'playing' : block.type}.png`} |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
No description provided.