Skip to content

Commit

Permalink
🐛 Fix issue where icon was hiding while document still loading
Browse files Browse the repository at this point in the history
  • Loading branch information
kierandrewett committed Dec 18, 2023
1 parent f10d425 commit fc0946a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions components/tabs/content/browser-internal-tab.js
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,7 @@ class BrowserTab extends MozElements.MozTab {

const shouldHideIcon =
(!iconURI.length || iconURI == BrowserTabsUtils.DEFAULT_TAB_ICON) &&
!this.linkedBrowser?.docShell?.isLoadingDocument &&
!initial;

if (shouldHideIcon) {
Expand Down
2 changes: 2 additions & 0 deletions third_party/dothq/gecko-types/lib/nsIDocShell.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,6 @@ export interface nsIDocShell {
doCommandWithParams(command: string, params: /* @todo nsICommandParams */ any): void;

QueryInterface: (obj: any) => any;

isLoadingDocument: boolean;
}

0 comments on commit fc0946a

Please sign in to comment.