Propose introducing codeowners for GitHub reviewer assignent #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junlarsen
force-pushed
the
01-25-propose_introducing_codeowners_for_github_reviewer_assignent
branch
from
10ffbd2 to
0ed7695
Compare
junlarsen
requested review from
jotjern,
henrikhorluck,
brage-andreas,
Terbau,
henrikskog and
madsab
henrikskog
reviewed
Jan 25, 2025
Co-authored-by: Henrik Skog <[email protected]>
henrikskog
approved these changes
Jan 25, 2025
|
Kult, vi tester. La oss fjerne det igjen hvis det ikke viser seg å være nyttig for oss. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces (and suggests some codeowners to begin with) that we use GitHub codeowners feature for auto-assigning reviewers to pull requests.
Historically speaking we haven't been the best at reviewing eachother's patches, so having GitHub autoassign somebody means contributors don't need to consider who to ask, and it's easier for people who wrote the code to see and follow updates.
I don't intend to take the name "codeowners" very seriously. It's just so GitHub can auto-assign reviewers.
This list is incomplete now, but I've proposed some initial codeowners for code I know people have worked a lot on. This also doesn't prevent others from chiming in on PRs, but it should hopefully help us forget about PRs.