-
Notifications
You must be signed in to change notification settings - Fork 539
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Unify how we resolve argument and env variables (#7360)
* Unify how we resolve argument and env variables - De-dupe the logic that we use to resolve environment variables and arguments in run and publish mode. This was done for both tests and product code. We now have a single way to resolve values. - Updated manifests * Fixed ArgumentEvaluator * Pass the container host name * Fix the container host name
- Loading branch information
Showing
18 changed files
with
603 additions
and
341 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -72,4 +72,4 @@ | |
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
44 changes: 44 additions & 0 deletions
44
playground/signalr/SignalR.AppHost/signalrDefault.module.bicep
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| @description('The location for the resource(s) to be deployed.') | ||
| param location string = resourceGroup().location | ||
|
|
||
| param principalType string | ||
|
|
||
| param principalId string | ||
|
|
||
| resource signalrDefault 'Microsoft.SignalRService/signalR@2024-03-01' = { | ||
| name: take('signalrDefault-${uniqueString(resourceGroup().id)}', 63) | ||
| location: location | ||
| properties: { | ||
| cors: { | ||
| allowedOrigins: [ | ||
| '*' | ||
| ] | ||
| } | ||
| features: [ | ||
| { | ||
| flag: 'ServiceMode' | ||
| value: 'Default' | ||
| } | ||
| ] | ||
| } | ||
| kind: 'SignalR' | ||
| sku: { | ||
| name: 'Free_F1' | ||
| capacity: 1 | ||
| } | ||
| tags: { | ||
| 'aspire-resource-name': 'signalrDefault' | ||
| } | ||
| } | ||
|
|
||
| resource signalrDefault_SignalRAppServer 'Microsoft.Authorization/roleAssignments@2022-04-01' = { | ||
| name: guid(signalrDefault.id, principalId, subscriptionResourceId('Microsoft.Authorization/roleDefinitions', '420fcaa2-552c-430f-98ca-3264be4806c7')) | ||
| properties: { | ||
| principalId: principalId | ||
| roleDefinitionId: subscriptionResourceId('Microsoft.Authorization/roleDefinitions', '420fcaa2-552c-430f-98ca-3264be4806c7') | ||
| principalType: principalType | ||
| } | ||
| scope: signalrDefault | ||
| } | ||
|
|
||
| output hostName string = signalrDefault.properties.hostName |
54 changes: 54 additions & 0 deletions
54
playground/signalr/SignalR.AppHost/signalrServerless.module.bicep
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| @description('The location for the resource(s) to be deployed.') | ||
| param location string = resourceGroup().location | ||
|
|
||
| param principalType string | ||
|
|
||
| param principalId string | ||
|
|
||
| resource signalrServerless 'Microsoft.SignalRService/signalR@2024-03-01' = { | ||
| name: take('signalrServerless-${uniqueString(resourceGroup().id)}', 63) | ||
| location: location | ||
| properties: { | ||
| cors: { | ||
| allowedOrigins: [ | ||
| '*' | ||
| ] | ||
| } | ||
| features: [ | ||
| { | ||
| flag: 'ServiceMode' | ||
| value: 'Serverless' | ||
| } | ||
| ] | ||
| } | ||
| kind: 'SignalR' | ||
| sku: { | ||
| name: 'Free_F1' | ||
| capacity: 1 | ||
| } | ||
| tags: { | ||
| 'aspire-resource-name': 'signalrServerless' | ||
| } | ||
| } | ||
|
|
||
| resource signalrServerless_SignalRAppServer 'Microsoft.Authorization/roleAssignments@2022-04-01' = { | ||
| name: guid(signalrServerless.id, principalId, subscriptionResourceId('Microsoft.Authorization/roleDefinitions', '420fcaa2-552c-430f-98ca-3264be4806c7')) | ||
| properties: { | ||
| principalId: principalId | ||
| roleDefinitionId: subscriptionResourceId('Microsoft.Authorization/roleDefinitions', '420fcaa2-552c-430f-98ca-3264be4806c7') | ||
| principalType: principalType | ||
| } | ||
| scope: signalrServerless | ||
| } | ||
|
|
||
| resource signalrServerless_SignalRRestApiOwner 'Microsoft.Authorization/roleAssignments@2022-04-01' = { | ||
| name: guid(signalrServerless.id, principalId, subscriptionResourceId('Microsoft.Authorization/roleDefinitions', 'fd53cd77-2268-407a-8f46-7e7863d0f521')) | ||
| properties: { | ||
| principalId: principalId | ||
| roleDefinitionId: subscriptionResourceId('Microsoft.Authorization/roleDefinitions', 'fd53cd77-2268-407a-8f46-7e7863d0f521') | ||
| principalType: principalType | ||
| } | ||
| scope: signalrServerless | ||
| } | ||
|
|
||
| output hostName string = signalrServerless.properties.hostName |
Oops, something went wrong.