Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the slim builder to avoid loading static assets #2013

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

davidfowl
Copy link
Member

@davidfowl davidfowl commented Jan 31, 2024

  • We're exposing a simple gRPC endpoint for the dashboard to talk to. We can avoid loading static assets completely (which causes all kinds of problems when things get out of sync).

Fixes #2012

Microsoft Reviewers: Open in CodeFlow

- We're exposing a simple gRPC endpoint for the dashboard to talk to. We can avoid loading static assets completely (which causes all kinds of problems when things get out of sync).

Fixes #2012
@davidfowl davidfowl merged commit eb62805 into main Jan 31, 2024
8 checks passed
@davidfowl davidfowl deleted the davidfowl/stop-loading-static-assets branch January 31, 2024 14:56
@davidfowl
Copy link
Member Author

/backport to release/8.0-preview3

Copy link
Contributor

Started backporting to release/8.0-preview3: https://github.com/dotnet/aspire/actions/runs/7727957215

radical pushed a commit to radical/aspire that referenced this pull request Feb 2, 2024
- We're exposing a simple gRPC endpoint for the dashboard to talk to. We can avoid loading static assets completely (which causes all kinds of problems when things get out of sync).

Fixes dotnet#2012
radical pushed a commit to radical/aspire that referenced this pull request Feb 6, 2024
- We're exposing a simple gRPC endpoint for the dashboard to talk to. We can avoid loading static assets completely (which causes all kinds of problems when things get out of sync).

Fixes dotnet#2012
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants