Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix container tags comments #6747

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix container tags comments #6747

wants to merge 2 commits into from

Conversation

sebastienros
Copy link
Member

@sebastienros sebastienros commented Nov 20, 2024

Description

Some changes that were done in release/9.0 were not merged back to main due to conflicts. This is fixing it. This should supersede #6718 which was opting to point to the <summary/> tag instead, but this would be opposite to what we have in release/9.0.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

@sebastienros
Copy link
Member Author

@eerhardt I couldn't understand some of your comments on the other PR, like #6718 (comment) and #6718 (comment). I don't any issue with these.

@eerhardt
Copy link
Member

@eerhardt I couldn't understand some of your comments on the other PR, like #6718 (comment) and #6718 (comment). I don't any issue with these.

For the comment (Although, that EventHubs one appears misplaced. It should be on the RunAsEmulator method.) I've pushed an update to this PR to move the remarks to the correct method. The 3 I pointed to weren't updated in #6718. But they are updated here now (using the other way).

For the 2 in AzureOpenAIDeployment - you can see on the docs site that it isn't working:

https://learn.microsoft.com/en-us/dotnet/api/aspire.hosting.applicationmodel.azureopenaideployment.skuname?view=dotnet-aspire-9.0

image

@sebastienros
Copy link
Member Author

Thanks. The missing resolution in the docs site is probably something to fix in the docs generation, and if we can't then we may want to change this in the code and remove these substitutions.

I checked for the tags and they don't work either, assuming that the docs are based on release/9.0 and not main.

@IEvangelist do you think there is a possibility this gets fixed in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants