-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the ResourceReadyEvent to block waiters #7163
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This allows more easier coordination after a resource is healthy but before waiters are unblocked. This is useful for seeding etc.
3 tasks
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
JamesNK
reviewed
Jan 20, 2025
JamesNK
reviewed
Jan 21, 2025
src/Aspire.Hosting/ApplicationModel/ResourceNotificationService.cs
Outdated
Show resolved
Hide resolved
- Don't rely on IsCompleted for the event update.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This is the reason I had to use a health check to seed the containers/dbs in the event hub host integration. With that I could move the logic there and use the standard health check. |
JamesNK
approved these changes
Jan 22, 2025
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I'm led to believe that this PR is either causing problems with these tests or exposing flakiness somewhere. |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When trying to write code that runs after a resource becomes healthy but before waiters are unblocked it requires complex coordination and a deep understanding of the resource lifecycle. This defaults to blocking waiters until the event is ready, allows users to build pretty nice experiences without complex coordination logic across resources.
Fixes #7164
Checklist
<remarks />
and<code />
elements on your triple slash comments?breaking-change
template):doc-idea
template):