[Testing] Populate AppHost environment from launch profile and support launch profile override #7363
+311
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…launch profile override
davidfowl
reviewed
Feb 1, 2025
Comment on lines
166
to
169
| SetDefault("DcpPublisher:ContainerRuntimeInitializationTimeout", "00:00:30"); | ||
| SetDefault("DcpPublisher:RandomizePorts", "true"); | ||
| SetDefault("DcpPublisher:DeleteResourcesOnShutdown", "true"); | ||
| SetDefault("DcpPublisher:ResourceNameSuffix", $"{Random.Shared.Next():x}"); |
There was a problem hiding this comment.
We should consider making some of these first class.
There was a problem hiding this comment.
Eg, by giving them a publicly accessible type or property? Agreed.
There was a problem hiding this comment.
Yep, file an issue for this one.
There was a problem hiding this comment.
I did a quick write-up #7365
davidfowl
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5093
This PR simulates launch profile loading for the testing host. It does not mutate the process' environment since that could cause issues with concurrently running tests. Instead, it propagates the environment variables specified in the AppHost's launch profile to the AppHost's configuration.
This PR sets the
DOTNET_LAUNCH_PROFILEenvironment variable to the name of the first launch profile if not overridden. It does not consider theDOTNET_LAUNCH_PROFILEfrom the test runner's environment.Checklist