Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-BuildManaged -BuildInstallers doesn't work as installer build too early #58984

Open
ViktorHofer opened this issue Nov 15, 2024 · 2 comments · May be fixed by #58987
Open

-BuildManaged -BuildInstallers doesn't work as installer build too early #58984

ViktorHofer opened this issue Nov 15, 2024 · 2 comments · May be fixed by #58987
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Comments

@ViktorHofer
Copy link
Member

When building installers without first building the rest of the repository (managed + native) in a previous build execution, the build fails as the installer build runs too early. This is probably not a problem as that's not a common workflow but with the VMR we need to be able to build the entire repository in one go.

Blocks dotnet/sdk#44828

The solution that I'm thinking of is adding a Traversal project that builds the installer projects and adding that to eng/Build.props at the very end with a BuildInParallel=false metadata so that it runs after everything else. The installer project will still build in parallel.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 15, 2024
@ViktorHofer
Copy link
Member Author

cc @wtgodbe

ViktorHofer added a commit that referenced this issue Nov 15, 2024
@ViktorHofer
Build installers at the end of the repo build
4de0a68 
Build the Installer projects after everythign else
got built by adding a new Traversal project that
builds all P2Ps in it in parallel.

Fixes #58984
Unblocks dotnet/sdk#44828
@ViktorHofer ViktorHofer linked a pull request Nov 15, 2024 that will close this issue
Open
4 tasks
ViktorHofer added a commit that referenced this issue Nov 15, 2024
@ViktorHofer
Build installers at the end of the repo build
acd5702 
Build the Installer projects after everythign else
got built by adding a new Traversal project that
builds all P2Ps in it in parallel.

Fixes #58984
Unblocks dotnet/sdk#44828
@wtgodbe
Copy link
Member

wtgodbe commented Nov 19, 2024

Yeah, our workflow for installers has always been to build them in a separate invocation of build.cmd, after the main repo build. This isn't great, but has never really been a problem since almost nobody ever needs to build the installers locally. I'd be happy to change it in the repo if the VMR solution works, it would simplify our CI/logical model

ViktorHofer added a commit that referenced this issue Nov 20, 2024
@ViktorHofer
Build installers at the end of the repo build
b6f68aa 
Build the Installer projects after everythign else
got built by adding a new Traversal project that
builds all P2Ps in it in parallel.

Fixes #58984
Unblocks dotnet/sdk#44828
ViktorHofer added a commit that referenced this issue Nov 21, 2024
@ViktorHofer
Build installers at the end of the repo build
ee5313e 
Build the Installer projects after everythign else
got built by adding a new Traversal project that
builds all P2Ps in it in parallel.

Fixes #58984
Unblocks dotnet/sdk#44828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
.NET Unified Build
Status: No status
Milestone
No milestone
2 participants
@ViktorHofer @wtgodbe